Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cifs-utils: 6.9 -> 6.12 #110014

Merged
merged 1 commit into from Jan 19, 2021
Merged

cifs-utils: 6.9 -> 6.12 #110014

merged 1 commit into from Jan 19, 2021

Conversation

LeSuisse
Copy link
Contributor

Motivation for this change

This notably fixes CVE-2020-14342.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110014 run on x86_64-linux 1

5 packages built:
  • autofs5
  • cifs-utils (cifs_utils)
  • rmount
  • roon-server
  • sssd

@SuperSandro2000
Copy link
Member

Does this require a backport?

@SuperSandro2000 SuperSandro2000 merged commit 28d1119 into NixOS:master Jan 19, 2021
@LeSuisse
Copy link
Contributor Author

Yes, it probably should.
Is it OK if I cherry pick this change directly or should I pull only the patch for the security issue to avoid introducing other changes in the stable branch?

@SuperSandro2000
Copy link
Member

Yes, it probably should.
Is it OK if I cherry pick this change directly or should I pull only the patch for the security issue to avoid introducing other changes in the stable branch?

Is there are no breaking changes I would be fine just creating this as a PR according to the backporting guide.

@LeSuisse LeSuisse deleted the cifs-utils-6.12 branch January 20, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LeSuisse @SuperSandro2000