itch: init at version v1.24.0 #110012
Closed
itch: init at version v1.24.0 #110012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add setup for itch.io desktop client. From issue NixOS#90233
pkgs/games/itch/default.nix
Outdated
| name = "itch-setup-${version}"; | ||
|
|
||
| src = fetchurl { | ||
| url = "https://github.com/itchio/itch-setup/archive/${version}.tar.gz"; |
There was a problem hiding this comment.
Please use fetchFromGitHub.
Comment on lines
+21
to
+23
| buildInputs = [ | ||
| makeWrapper nodejs go glib | ||
| ]; |
There was a problem hiding this comment.
Suggested change
| buildInputs = [ | |
| makeWrapper nodejs go glib | |
| ]; | |
| buildInputs = [ | |
| nodejs go glib | |
| ]; |
| homepage = "https://itch.io"; | ||
| description = | ||
| "A desktop application that you can download and run games from itch.io with."; | ||
| license = licenses.mit; |
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
SuperSandro2000
requested changes
Jan 22, 2021
Comment on lines
+10
to
+13
| let | ||
| lib = stdenv.lib; | ||
| in | ||
| stdenv.mkDerivation rec { |
There was a problem hiding this comment.
Suggested change
| let | |
| lib = stdenv.lib; | |
| in | |
| stdenv.mkDerivation rec { | |
| stdenv.mkDerivation rec { |
| @@ -0,0 +1,60 @@ | |||
| { stdenv | |||
There was a problem hiding this comment.
Suggested change
| { stdenv | |
| { stdenv | |
| , lib |
| @@ -26459,6 +26459,8 @@ in | |||
| # used as base package for iortcw forks | |||
| iortcw_sp = callPackage ../games/iortcw/sp.nix { }; | |||
|
|
|||
| itch = callPackage ../games/itch/default.nix { }; | |||
There was a problem hiding this comment.
Suggested change
| itch = callPackage ../games/itch/default.nix { }; | |
| itch = callPackage ../games/itch/default.nix { }; |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
any updates on this? |
stale
bot
removed
the
2.status: stale
|
This PR is superseded by #157921. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add setup for itch.io desktop client. From issue #90233
Motivation for this change
Attempting to add the itch.io desktop client via the itch-setup utility. See issue #90233.
Things done
Tried to base it on other electron app expressions without success.
Currently it is failing, but I'm hoping someone knows how to fix it.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)