Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maude: 3.0 -> 3.1 #109964

Merged
merged 1 commit into from Jan 19, 2021
Merged

maude: 3.0 -> 3.1 #109964

merged 1 commit into from Jan 19, 2021

Conversation

bitmappergit
Copy link
Contributor

@bitmappergit bitmappergit commented Jan 19, 2021 •
edited

Updated Maude from 3.0 to 3.1.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Jan 19, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the contribution guide the PR title and commit message should be maude: 3.0 -> 3.1

@ofborg ofborg bot requested a review from peti January 19, 2021 14:36
@bitmappergit bitmappergit changed the title Update Maude to 3.1 maude: 3.0 -> 3.1 Jan 19, 2021
@bitmappergit
Copy link
Contributor Author

bitmappergit commented Jan 19, 2021 •
edited

Ah! Sorry, I knew I shouldn't have done this in the morning.
Do you want me to close the pull request and correct the commit message?

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 19, 2021 •
edited

Do you want me to close the pull request and correct the commit message?

Please do a force push. It is not required to open a new PR.

@bitmappergit
Copy link
Contributor Author

All good?

@peti peti merged commit 45c9550 into NixOS:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bitmappergit @SuperSandro2000 @peti