Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opentabletdriver: 0.4.2 -> 0.5.0 #109966

Merged
merged 2 commits into from Jan 20, 2021
Merged

opentabletdriver: 0.4.2 -> 0.5.0 #109966

merged 2 commits into from Jan 20, 2021

Conversation

thiagokokada
Copy link
Contributor

@thiagokokada thiagokokada commented Jan 19, 2021 •
edited

Motivation for this change

https://github.com/InfinityGhost/OpenTabletDriver/releases/tag/v0.5.0

Also, did some improvements in ./update.sh script making it finally possible to set it in passthru.updateScript.

Had to disable testing the otd binary for now, but the rest of the test seems fine and I also did a manual testing in my machine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thiagokokada
opentabletdriver: improve update.sh script
9887302 
Allow it to update deb package sha256 automatically.
@thiagokokada
Copy link
Contributor Author

Result of nixpkgs-review pr 109966 run on x86_64-linux 1

1 package built:
  • opentabletdriver

@thiagokokada
Copy link
Contributor Author

@GrahamcOfBorg build opentabletdriver
@GrahamcOfBorg test opentabletdriver

@thiagokokada
Copy link
Contributor Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Jan 20, 2021

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot requested a review from kevincox January 20, 2021 01:26
@kevincox kevincox merged commit f1d3b04 into NixOS:master Jan 20, 2021
@thiagokokada thiagokokada deleted the bump-opentabletdriver branch January 20, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincox kevincox kevincox approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thiagokokada @kevincox