Skip to content

nixos/chromium: Set policy DefaultSearchProviderEnabled #109913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

nixos/chromium: Set policy DefaultSearchProviderEnabled #109913

wants to merge 1 commit into from
+1 −0

Conversation

jD91mZM2
Copy link
Member

@jD91mZM2 jD91mZM2 commented Jan 19, 2021 •
edited
Loading

Motivation for this change

ungoogled-chromium will have this off by default, so to make the defaultSearchProviderSearchURL option work there we'll need to set this explicitly. Seems like a good idea regardless.

EDIT: Not just ungoogled-chromium. Normal chromium has this problem as well - I need to set it for these options to have any effect

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@jD91mZM2
nixos/chromium: Set policy DefaultSearchProviderEnabled

Verified

This commit was signed with the committer’s verified signature.
infinisil Silvan Mosberger
GPG key ID: 9424360B4B85C9E7
Verified
Learn about vigilant mode
921b358 
ungoogled-chromium will have this off by default, so to make the
defaultSearchProviderSearchURL option work there we'll need to set this
explicitly. Seems like a good idea regardless.
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 19, 2021
@stale
Copy link

stale bot commented Jul 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@Artturin Artturin closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jD91mZM2 @Artturin