Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spacevim: 1.5.0 -> 1.6.0 #109983

Merged
merged 1 commit into from Feb 20, 2021
Merged

spacevim: 1.5.0 -> 1.6.0 #109983

merged 1 commit into from Feb 20, 2021

Conversation

bbjubjub2494
Copy link
Member

Motivation for this change

I saw there's a new upstream release.

ping @fzakaria

Changelog

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from fzakaria January 19, 2021 17:20
@bbjubjub2494 bbjubjub2494 marked this pull request as ready for review January 19, 2021 17:22
@fzakaria
Copy link
Contributor

Have you tried it ?
Just want to make sure the patch file still works.

@bbjubjub2494
Copy link
Member Author

Have you tried it ?
Just want to make sure the patch file still works.

Yes it builds and runs. The patch is offset by 100 lines though according to build logs.

@bbjubjub2494
Copy link
Member Author

bbjubjub2494 commented Jan 19, 2021 •
edited

If I may, I'll nitpick myself and resolve that issue, especially given that it creates a .orig file in the output otherwise.

EDIT: I mean the patch offset thing

@ofborg ofborg bot requested a review from fzakaria January 19, 2021 18:27
@bbjubjub2494 bbjubjub2494 mentioned this pull request Feb 20, 2021
Merged
10 tasks
AndersonTorres
AndersonTorres approved these changes Feb 20, 2021
View reviewed changes
Copy link
Member

@AndersonTorres AndersonTorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a VI user.

The diff looks OK to me.

@AndersonTorres AndersonTorres merged commit f288a8c into NixOS:master Feb 20, 2021
@bbjubjub2494 bbjubjub2494 mentioned this pull request Feb 21, 2021
Closed
@bbjubjub2494 bbjubjub2494 deleted the update/spacevim branch July 1, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzakaria fzakaria fzakaria approved these changes

@AndersonTorres AndersonTorres AndersonTorres approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bbjubjub2494 @fzakaria @AndersonTorres