Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6dfd1a277281
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6b755ab26d6c
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Jan 18, 2021

  1. jmeter: 5.1.1 > 5.4 

    Update Jmeter to the latest version, also add myself as a maintainer

I have been using the package for 5 months daily, at the moment I am aware of 3 bugs.

1. Jmeter fails to save test plan in /nix/store (by default it saves it where Jmeter was installed).

2. The test fails to run on the latest version complaining about some missing libraries, for example log4j.

3. Jmeter fails to generate the report from a JTL file, for some reason it is not copying the needed files sometimes it fails without any log or error.

The rest works perfectly, but I still plan to fix it at somepoint, as I only use it for development, I didn't find any other bugs, and in the case of the report generator it is possible to generate it during the test run (in my case, the test is run on a non-NIXOS machine) or in a container.

Also add why tests are disabled.

Signed-off-by: Bryan A. S <bryanasdev000@gmail.com>
    @bryanasdev000
    bryanasdev000 committed Jan 18, 2021
    Copy the full SHA
    c48a355 View commit details

Commits on Jan 19, 2021

  1. Merge pull request #109498 from bryanasdev000/package-jmeter 

    jmeter: 5.1.1 > 5.4
    @SuperSandro2000
    SuperSandro2000 authored Jan 19, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    6b755ab View commit details
Showing with 5 additions and 5 deletions.
  1. +5 −5 pkgs/applications/networking/jmeter/default.nix
10 changes: 5 additions & 5 deletions pkgs/applications/networking/jmeter/default.nix
View file
Original file line number Diff line number Diff line change
@@ -2,13 +2,13 @@

stdenv.mkDerivation rec {
pname = "jmeter";
version = "5.1.1";
version = "5.4";
src = fetchurl {
url = "https://archive.apache.org/dist/jmeter/binaries/apache-${pname}-${version}.tgz";
sha256 = "1bmlxnlcias781mwf3wzpd4935awswbq3w8ijck65bsaw07m2kc4";
sha256 = "1hbyvh0hrvfvrsf7wpnwqsry5gaziac632s0bwb5zbq6y5b0z41a";
};

nativeBuildInputs = [ makeWrapper ];
nativeBuildInputs = [ makeWrapper jre ];

installPhase = ''
mkdir $out
@@ -32,7 +32,7 @@ stdenv.mkDerivation rec {
wrapProgram $out/bin/jmeter.sh --set JAVA_HOME "${jre}"
'';

doInstallCheck = true;
doInstallCheck = false; #NoClassDefFoundError: org/apache/logging/log4j/Level for tests

checkInputs = [ coreutils ];

@@ -53,7 +53,7 @@ stdenv.mkDerivation rec {
Applications but has since expanded to other test functions.
'';
license = licenses.asl20;
maintainers = [ ];
maintainers = [ maintainers.bryanasdev000 ];
priority = 1;
platforms = platforms.unix;
};