Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] dnsmasq: 2.82 -> 2.83 #109971

Merged
merged 1 commit into from Jan 21, 2021
Merged

[20.09] dnsmasq: 2.82 -> 2.83 #109971

merged 1 commit into from Jan 21, 2021

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Jan 19, 2021

Motivation for this change

Backport of #109968

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from edolstra, fpletz and globin January 19, 2021 15:22
@stigtsp stigtsp requested a review from mweinelt January 19, 2021 15:28
@stigtsp stigtsp force-pushed the package/dnsmasq-2.83-staging-20.09 branch from 6da0cb3 to 911daca Compare January 19, 2021 15:38
@stigtsp stigtsp marked this pull request as draft January 19, 2021 15:56
@stigtsp stigtsp force-pushed the package/dnsmasq-2.83-staging-20.09 branch from 911daca to de0429c Compare January 19, 2021 19:24
@stigtsp stigtsp marked this pull request as ready for review January 19, 2021 21:24
@FlorianFranzen
Copy link
Contributor

@NixOS/backports Would be nice if you could take a look, as this is a somewhat serious security fix.

mweinelt
mweinelt approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks good to me.

@mweinelt mweinelt added this to Ready in Staging (stable) Jan 21, 2021
@mweinelt
Copy link
Member

I'm going to forgo batching this, since there is nothing else ready right now.

@mweinelt mweinelt merged commit ebf2fa5 into NixOS:staging-20.09 Jan 21, 2021
Staging (stable) automation moved this from Ready to Done Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
Staging (stable)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stigtsp @FlorianFranzen @mweinelt