Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New parts setting cause fuzzer to fail if ran from the fuzzer directory #1557

Closed
acomodi opened this issue Jan 19, 2021 · 2 comments · Fixed by #1559
Closed

New parts setting cause fuzzer to fail if ran from the fuzzer directory #1557

acomodi opened this issue Jan 19, 2021 · 2 comments · Fixed by #1559
Assignees
@acomodi

Comments

@acomodi
Copy link
Contributor

acomodi commented Jan 19, 2021

With the new way of generalizing the various parts, all the required environment variables to correctly run the fuzzers are set in the run_fuzzer.py script (e.g. XRAY_FABRIC, XRAY_PIN_XX).

This causes issues during fuzzer developement, as the environment is incomplete when running the fuzzer without invoking the run_fuzzer.py script, resulting in fuzzer failures.
@litghost
Copy link
Contributor

litghost commented Jan 19, 2021 •
edited

@acomodi We should be able to refactor the setenv portion of run_fuzzer.py. If we write a tool that outputs bash "export ...=..." then something like:

eval $(python3 ${XRAY_UTILS}/create_environment.py --part ${XRAY_PART})

Where create_environment.py --part ${XRAY_PART} outputs:

export XRAY_FABRIC=...
... etc ...

That make sense?

@acomodi
Copy link
Contributor Author

acomodi commented Jan 19, 2021

@litghost Sure, I think this is a good solution, thanks

@acomodi acomodi self-assigned this Jan 19, 2021
@acomodi acomodi mentioned this issue Jan 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acomodi acomodi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

environment: fix environment set up antmicro/prjxray
2 participants
@litghost @acomodi