Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

carps-cups: init at unstable-2018-03-05 #107313

Merged
merged 2 commits into from Jan 19, 2021
Merged

carps-cups: init at unstable-2018-03-05 #107313

merged 2 commits into from Jan 19, 2021

Conversation

ewok-old
Copy link
Contributor

Motivation for this change

Adding support for old Canon printers(from project page):

Printer Status
MF5730 works
MF5750 works
MF5770 should work
MF5630 works
MF5650 should work
MF3110 works
imageCLASS D300 works
LASERCLASS 500 should work
FP-L170/MF350/L380/L398 should work
LC310/L390/L408S works
PC-D300/FAX-L400/ICD300 works
L180/L380S/L398S works
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ewok-old
Copy link
Contributor Author

I have MF3110 tested it works

SuperSandro2000
SuperSandro2000 requested changes Jan 18, 2021
View reviewed changes
pkgs/misc/cups/drivers/carps-cups/default.nix Outdated Show resolved Hide resolved
pkgs/misc/cups/drivers/carps-cups/default.nix Outdated Show resolved Hide resolved
pkgs/misc/cups/drivers/carps-cups/default.nix Outdated Show resolved Hide resolved
pkgs/misc/cups/drivers/carps-cups/default.nix Outdated Show resolved Hide resolved
@ewok-old ewok-old changed the title carps-cups: init at 18d80d1 carps-cups: init at unstable-2018-03-05 Jan 18, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 107313 run on x86_64-linux 1

1 package built:
  • carps-cups

@SuperSandro2000 SuperSandro2000 merged commit d1bfbb9 into NixOS:master Jan 19, 2021
@ewok-old ewok-old deleted the carps-cups branch April 12, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
6.topic: printing 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ewok-old @SuperSandro2000