gperftools: drop an option that seems no longer supported #109996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> warning: unknown warning option '-Wno-aligned-allocation-unavailable'; > did you mean '-Wno-debug-compression-unavailable'? [-Wunknown-warning-option]
|
It's de-facto revert of 6a560f4 |
vcunat
added
6.topic: darwin
|
We were getting the warning even previously, but before it wasn't leading to this fatal problem. Most likely that was triggered by the autoconf update – default, we still keep 269 and could switch to it selectively. |
| @@ -34,7 +34,7 @@ stdenv.mkDerivation rec { | |||
| ''; | |||
|
|
|||
| NIX_CFLAGS_COMPILE = stdenv.lib.optionalString stdenv.isDarwin | |||
There was a problem hiding this comment.
Suggested change
| NIX_CFLAGS_COMPILE = stdenv.lib.optionalString stdenv.isDarwin | |
| NIX_CFLAGS_COMPILE = lib.optionalString stdenv.isDarwin |
stdenv.lib is deprecated.
There was a problem hiding this comment.
OK, I'd fix all the places in this file at once. Can you link the deprecation?
There was a problem hiding this comment.
You could have searched that yourself.
|
I confirm that removing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only darwin gets rebuilt, but it needs to be tested.