Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.url-normalize: init at 1.4.3 #109994

Merged
merged 2 commits into from Jan 19, 2021
Merged

python3Packages.url-normalize: init at 1.4.3 #109994

merged 2 commits into from Jan 19, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 19, 2021

Motivation for this change

URL normalization for Python

https://github.com/niksite/url-normalize

This is a Home Assistant dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda
Copy link
Member

@fabaff Why update component-packages.nix if both components using url-normalize are still missing something else?

dotlambda
dotlambda requested changes Jan 19, 2021
View reviewed changes
pkgs/development/python-modules/url-normalize/default.nix
version = "1.4.3";
format = "pyproject";

src = fetchFromGitHub {
Copy link
Member

@dotlambda dotlambda Jan 19, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not fetchPypi? In case that applies, you should add a comment that tests are missing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a lot of packages have that and I wouldn't nit people about it. So it is nice to have but not hard required.

pkgs/development/python-modules/url-normalize/default.nix Show resolved Hide resolved
@fabaff
Copy link
Member Author

fabaff commented Jan 19, 2021

Result of nixpkgs-review pr 109994 run on x86_64-linux 1

1 package failed to build:
  • python37Packages.url-normalize
1 package built:
  • python38Packages.url-normalize

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109994 run on x86_64-linux 1

2 packages built:
  • python37Packages.url-normalize
  • python38Packages.url-normalize

@fabaff
Copy link
Member Author

fabaff commented Jan 19, 2021

@fabaff Why update component-packages.nix if both components using url-normalize are still missing something else?

Because component-packages.nix is updated every time parse-requirements.py is run. If we don't update component-packages.nix when a new dependency is available then we end up with conflicts. I tried to de-couple the update of component-packages.nix from the dependency addition (mainly to reduce the amount of commits) but the next person had to update the file, parse-requirements.py picked-up both dependencies and this is not an ideal situation if stuff has to be reverted.

@SuperSandro2000 SuperSandro2000 merged commit 6b0fe63 into NixOS:master Jan 19, 2021
@fabaff fabaff mentioned this pull request Jan 19, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @dotlambda @SuperSandro2000