Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs-modes: Fix missing 'lib' arguments #109954

Merged
merged 1 commit into from Jan 19, 2021
Merged

emacs-modes: Fix missing 'lib' arguments #109954

merged 1 commit into from Jan 19, 2021

Conversation

SFrijters
Copy link
Member

Motivation for this change

@siraben The ongoing work on #108938 seems to have broken some emacs modes. In particular, tramp was broken for me, but I've added the argument to all other emacs-modes files touched in the same commit.

nixpkgs-review doesn't seem to do anything: Nothing to be built.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SFrijters SFrijters changed the title emacs-modes: Add missing 'lib' arguments emacs-modes: Fix missing 'lib' arguments Jan 19, 2021
@sternenseemann
Copy link
Member

@SFrijters ofborg found another, maybe unrelated eval error. Can you fix it and include the fix in this PR, please?

@SFrijters
Copy link
Member Author

As far as I understand it is indeed unrelated, so I created a separate PR for it at #109959.

@sternenseemann
Copy link
Member

@SFrijters Since the PR is merged already, try rebasing on master so the ofborg check (hopefully) passes.

@adisbladis
Copy link
Member

I have rebased this on latest master. Just waiting for ofborg to complete but all changes LGTM.

SuperSandro2000
SuperSandro2000 approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@adisbladis adisbladis merged commit 56caedf into NixOS:master Jan 19, 2021
@SFrijters SFrijters deleted the add-missing-lib-emacs-modes branch February 18, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

@siraben siraben Awaiting requested review from siraben

Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SFrijters @sternenseemann @adisbladis @SuperSandro2000