Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lsyncd: build on darwin #109981

Merged
merged 2 commits into from Jan 24, 2021
Merged

lsyncd: build on darwin #109981

merged 2 commits into from Jan 24, 2021

Conversation

nmattia
Copy link
Contributor

@nmattia nmattia commented Jan 19, 2021

This adds some CMake flags that allow building lsyncd on Darwin.

Motivation for this change

I'd like to use lsyncd on Darwin.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 19, 2021
@basvandijk
Copy link
Member

@GrahamcOfBorg build lsyncd

@ofborg ofborg bot requested a review from bobvanderlinden January 19, 2021 16:27
@SuperSandro2000
Copy link
Member

Shouldn't ofborg mark a darwin rebuild? Maybe check if you missed something.

@nmattia
lsyncd: build on darwin
19ade64 
This adds some CMake flags that allow building lsyncd on Darwin.
@basvandijk
Copy link
Member

@GrahamcOfBorg build lsyncd

basvandijk
basvandijk approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@basvandijk basvandijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems ofborg is stuck on darwin. Let's see if it gets unstuck this time around. If it doesn't we can merge it since you built it on darwin already anyway.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109981 run on x86_64-darwin 1

1 package built:
  • lsyncd

@nmattia @SuperSandro2000
Update pkgs/applications/networking/sync/lsyncd/default.nix
3c39e60 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000 SuperSandro2000 merged commit e63d073 into NixOS:master Jan 24, 2021
@nmattia nmattia deleted the nm-fix-lsyncd branch January 25, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@basvandijk basvandijk basvandijk approved these changes

@bobvanderlinden bobvanderlinden Awaiting requested review from bobvanderlinden

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nmattia @basvandijk @SuperSandro2000