Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updater-emacs: Add missing pkgs in path to withPackages #110626

Merged
merged 1 commit into from Jan 29, 2021
Merged

updater-emacs: Add missing pkgs in path to withPackages #110626

merged 1 commit into from Jan 29, 2021

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Jan 23, 2021

Motivation for this change

Add missing pkgs in path to withPackages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@talyz talyz requested a review from adisbladis January 23, 2021 20:38
@talyz talyz mentioned this pull request Jan 23, 2021
Closed
@terlar
Copy link
Contributor

terlar commented Jan 29, 2021

@adisbladis any chance to get this merged? 🥺

@adisbladis adisbladis merged commit fb38ac0 into NixOS:master Jan 29, 2021
@talyz talyz deleted the updater-emacs-fix branch June 16, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
6.topic: emacs 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@talyz @terlar @adisbladis