Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: stdenv.lib -> lib #110628

Merged
merged 1 commit into from Jan 24, 2021
Merged

treewide: stdenv.lib -> lib #110628

merged 1 commit into from Jan 24, 2021

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jan 23, 2021 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak force-pushed the stdenv-lib branch 2 times, most recently from d16d05d to 8906cd9 Compare January 23, 2021 21:19
@prusnak prusnak force-pushed the stdenv-lib branch 4 times, most recently from 967f268 to 0ef42c7 Compare January 23, 2021 23:21
SuperSandro2000
SuperSandro2000 approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this has zero rebuilds and ofborg passes we can merge this.

Edit: @prusnak and we got an eval error.

@prusnak prusnak force-pushed the stdenv-lib branch 3 times, most recently from 0ad1a31 to 74e801f Compare January 24, 2021 00:40
@ofborg ofborg bot removed the 6.topic: vim label Jan 24, 2021
@prusnak
Copy link
Member Author

prusnak commented Jan 24, 2021

Edit: @prusnak and we got an eval error.

Fixed

@SuperSandro2000 SuperSandro2000 merged commit 77f32f2 into NixOS:master Jan 24, 2021
@prusnak prusnak deleted the stdenv-lib branch January 24, 2021 10:34
@Radvendii Radvendii mentioned this pull request Apr 21, 2021
Merged
10 tasks
@tdemin tdemin mentioned this pull request Oct 10, 2021
Closed
tdemin added a commit to tdemin/nixpkgs that referenced this pull request Oct 10, 2021
@tdemin
releaseTools.debBuild: fix invocation
1c9afc5 
Somewhere after NixOS#110628, which replaced stdenv.lib with lib, up to
bug NixOS#134572, lib got removed from the argument list, breaking any
invocations of debBuild. This adds it back.
@tdemin tdemin mentioned this pull request Oct 10, 2021
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@andir andir Awaiting requested review from andir

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@jonringer jonringer Awaiting requested review from jonringer

@Lassulus Lassulus Awaiting requested review from Lassulus Lassulus is a code owner

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

@roberth roberth Awaiting requested review from roberth roberth is a code owner

@zowoq zowoq Awaiting requested review from zowoq zowoq is a code owner

Assignees
No one assigned
Labels
6.topic: fetch 6.topic: nixos 6.topic: policy discussion 6.topic: rust 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prusnak @SuperSandro2000