Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sord: 0.16.4 -> unstable-2021-01-12 #110612

Merged
merged 1 commit into from Jan 24, 2021
Merged

sord: 0.16.4 -> unstable-2021-01-12 #110612

merged 1 commit into from Jan 24, 2021

Conversation

kanashimia
Copy link
Member

@kanashimia kanashimia commented Jan 23, 2021 •
edited

Motivation for this change

Fix segfault.
Continuation of #110538
Getting source from master for now until release version is out.

Also apparently fetchFromGitLab doesn't fetch submodules?
And i'm not sure what should i put as a version if this is a commit from a master branch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from cillianderoiste January 23, 2021 17:36
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110612 run on x86_64-darwin 1

1 package built:
  • sord

@kanashimia kanashimia changed the title sord: 0.16.4 -> 0.16.8-20210112 sord: 0.16.4 -> unstable-2021-01-12 Jan 23, 2021
@SuperSandro2000
Copy link
Member

I just checked the NEWS file https://github.com/drobilla/sord/blob/master/NEWS and I think we want to update to 0.16.9 to avoid crashes with gcc10.

@kanashimia
Copy link
Member Author

@SuperSandro2000 Well there's no 0.16.9 release. Looking through logs i see "unstable" near the version there basically means that it is a pre release version, and some additional changes and testing are still to be made.

@SuperSandro2000 SuperSandro2000 merged commit 3676182 into NixOS:master Jan 24, 2021
@kanashimia kanashimia mentioned this pull request Feb 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kanashimia @SuperSandro2000