Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kind: 0.9.0 -> 0.10.0 #110563

Merged
merged 1 commit into from Jan 23, 2021
Merged

kind: 0.9.0 -> 0.10.0 #110563

merged 1 commit into from Jan 23, 2021

Conversation

dbirks
Copy link
Member

@dbirks dbirks commented Jan 23, 2021

Motivation for this change

Version 0.10.0 released today:
https://github.com/kubernetes-sigs/kind/releases/tag/v0.10.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hugolgst
Copy link
Member

Result of nixpkgs-review pr 110563 1

1 package built:
  • kind

hugolgst
hugolgst approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@hugolgst hugolgst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperSandro2000 SuperSandro2000 merged commit f0e117f into NixOS:master Jan 23, 2021
@dbirks dbirks deleted the kind-0.10.0 branch January 25, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugolgst hugolgst hugolgst approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

@rawkode rawkode Awaiting requested review from rawkode

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dbirks @hugolgst @SuperSandro2000