lua: Add more symlinks to lua.pc #110616
Merged
lua: Add more symlinks to lua.pc #110616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want to move this through staging? |
| ln -s "$out/lib/pkgconfig/lua.pc" "$out/lib/pkgconfig/lua${luaversion}.pc" | ||
| ln -s "$out/lib/pkgconfig/lua.pc" "$out/lib/pkgconfig/lua${stdenv.lib.replaceStrings [ "." ] [ "" ] luaversion}.pc" |
There was a problem hiding this comment.
Suggested change
| ln -s "$out/lib/pkgconfig/lua.pc" "$out/lib/pkgconfig/lua${stdenv.lib.replaceStrings [ "." ] [ "" ] luaversion}.pc" | |
| ln -s "$out/lib/pkgconfig/lua.pc" "$out/lib/pkgconfig/lua${lib.replaceStrings [ "." ] [ "" ] luaversion}.pc" |
|
the comparison with arch/debian is much appreciated. Fix @SuperSandro2000 's comment and I'll merge it. |
teto
approved these changes
Jan 23, 2021
This creates a symlink to lua.pc for every name of the file used by Arch: For a version of Lua (for example, 5.4) we now have: - lib/pkgconfig/lua.pc - lib/pkgconfig/lua-5.4.pc - lib/pkgconfig/lua5.4.pc - lib/pkgconfig/lua54.pc
ofborg
bot
added
10.rebuild-linux: 1001-2500
and removed
10.rebuild-linux: 501-1000
labels
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This is essentially a continuation of #42473. Some packages expect
lua53.pcto exist, but Nixpkgs currently only haslua.pcandlua5.3.pc. This creates a symlink to lua.pc for every name of the file used by Arch.For a version of Lua (for example, 5.4) there are now:
Compare the names used by Arch and Debian.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)