Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitkraken: 7.4.1 -> 7.5.0 #110561

Merged
merged 2 commits into from Jan 24, 2021
Merged

gitkraken: 7.4.1 -> 7.5.0 #110561

merged 2 commits into from Jan 24, 2021

Conversation

rhoriguchi
Copy link
Contributor

Motivation for this change

GitKraken version 7.5.0 has been released.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from evanjs January 23, 2021 02:19
dbirks
dbirks approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@dbirks dbirks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and ran on NixOS. Looks good 👍

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110561 run on x86_64-linux 1

1 package built:
  • gitkraken

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

gitkraken:

Please consider this feature to be alpha.

A substituteInPlace with an unmatched pattern got detected:

substituteStream(): WARNING: pattern '/nix/store/cyfdlhp29i2mwngz978aqqxdb8xhi43p-gitkraken-7.5.0/usr/share/gitkraken' doesn't match anything in file '/nix/store/cyfdlhp29i2mwngz978aqqxdb8xhi43p-gitkraken-7.5.0/share/applications/gitkraken.desktop'

Please check the offending substituteInPlace for typos or changes in source.

@rhoriguchi
Copy link
Contributor Author

rhoriguchi commented Jan 23, 2021 •
edited

@SuperSandro2000 is this even needed? The desktop file is created manually so there's not really a reason to substitute it.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 is this even needed? The desktop file is created manually so there's not really a reason to substitute it.

Does not look like it but I am not 100% sure.

@rhoriguchi
Copy link
Contributor Author

rhoriguchi commented Jan 23, 2021 •
edited

Does not look like it but I am not 100% sure.

After going through a couple of derivations that use makeDesktopItem I don't think it isn't necessary. Example

Edit: Error is gone

1 package built:
gitkraken

@evanjs
Copy link
Member

evanjs commented Jan 23, 2021

Does not look like it but I am not 100% sure.

After going through a couple of derivations that use makeDesktopItem I don't think it isn't necessary. Example

Edit: Error is gone

1 package built:
gitkraken

Yeah, probably an artifact from some other changes that was overlooked. Thanks for checking it out!

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110561 run on x86_64-linux 1

1 package built:
  • gitkraken

@SuperSandro2000 SuperSandro2000 merged commit 95f8678 into NixOS:master Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanjs evanjs evanjs approved these changes

@dbirks dbirks dbirks approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rhoriguchi @SuperSandro2000 @evanjs @dbirks