Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Validate against the byte length of strings, rather than their unicode length #80

Merged
merged 3 commits into from Jan 23, 2021
Merged

Fix: Validate against the byte length of strings, rather than their unicode length #80

merged 3 commits into from Jan 23, 2021

Conversation

LordAro
Copy link
Member

@LordAro LordAro commented Jan 23, 2021

@LordAro LordAro force-pushed the validate-bytes branch 3 times, most recently from 6c49d35 to ee41e9e Compare January 23, 2021 12:59
@LordAro
Copy link
Member Author

LordAro commented Jan 23, 2021

Suitably tested?

TrueBrain
TrueBrain reviewed Jan 23, 2021
View reviewed changes
bananas_api/helpers/api_schema.py Outdated Show resolved Hide resolved
bananas_api/helpers/api_schema.py Outdated Show resolved Hide resolved
@TrueBrain TrueBrain merged commit 0342a2b into OpenTTD:master Jan 23, 2021
@LordAro LordAro deleted the validate-bytes branch January 23, 2021 13:12
@LordAro LordAro mentioned this pull request Jan 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrueBrain TrueBrain TrueBrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LordAro @TrueBrain