Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron_11: 11.2.0 -> 11.2.1 #110578

Merged
merged 1 commit into from Jan 23, 2021
Merged

electron_11: 11.2.0 -> 11.2.1 #110578

merged 1 commit into from Jan 23, 2021

Conversation

TredwellGit
Copy link
Member

Motivation for this change

https://github.com/electron/electron/releases/tag/v11.2.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@TredwellGit TredwellGit added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 23, 2021
@hugolgst
Copy link
Member

Result of nixpkgs-review pr 110578 1

6 packages built:
  • _1password-gui
  • electron (electron_11)
  • element-desktop
  • nix-tour
  • obsidian
  • vieb

hugolgst
hugolgst approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@hugolgst hugolgst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110578 run on x86_64-linux 1

6 packages built:
  • _1password-gui
  • electron (electron_11)
  • element-desktop
  • nix-tour
  • obsidian
  • vieb

@prusnak prusnak merged commit 046a9cf into NixOS:master Jan 23, 2021
@prusnak
Copy link
Member

prusnak commented Jan 23, 2021

I cherry-picked the commit to my earlier PR with backport to stable: #109627

@TredwellGit TredwellGit deleted the electron_11 branch January 23, 2021 19:04
@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugolgst hugolgst hugolgst approved these changes

Assignees
No one assigned
Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TredwellGit @hugolgst @SuperSandro2000 @prusnak @erictapen