Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spdlog_1: add support for pkgsStatic #110586

Merged
merged 1 commit into from Jan 23, 2021

Conversation

tobim
Copy link
Contributor

@tobim tobim commented Jan 23, 2021

Things done

This causes 22 rebuilds according to nixpkgs-review:
bear cloudcompare gerbera hal-hardware-analyzer lizardfs mtxclient nheko pdal python3.7-qiskit python3.7-qiskit-aer python3.7-qiskit-aqua python3.7-qiskit-ignis python3.7-tiledb python3.8-qiskit python3.8-qiskit-aer python3.8-qiskit-aqua python3.8-qiskit-ignis python3.8-tiledb spdlog spdlog tiledb waybar

This could be avoided at the cost of a less readable construction of cmakeFlags until the next version bump.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110586 run on x86_64-darwin 1

4 packages marked as broken and skipped:
  • mtxclient
  • nheko
  • pdal
  • waybar
1 package failed to build and already failed to build on hydra master:
8 packages failed to build and are new build failures:
  • python37Packages.qiskit: log was empty
  • python37Packages.qiskit-aer: log was empty
  • python37Packages.qiskit-aqua: log was empty
  • python37Packages.qiskit-ignis: log was empty
  • python38Packages.qiskit: log was empty
  • python38Packages.qiskit-aer: log was empty
  • python38Packages.qiskit-aqua: log was empty
  • python38Packages.qiskit-ignis: log was empty
6 packages built:
  • hal-hardware-analyzer
  • python37Packages.tiledb
  • python38Packages.tiledb
  • spdlog (spdlog_1)
  • spdlog_0
  • tiledb

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110586 run on x86_64-linux 1

1 package failed to build and already failed to build on hydra master:
21 packages built:
  • bear
  • cloudcompare
  • gerbera
  • hal-hardware-analyzer
  • mtxclient
  • nheko
  • pdal
  • python37Packages.qiskit
  • python37Packages.qiskit-aer
  • python37Packages.qiskit-aqua
  • python37Packages.qiskit-ignis
  • python37Packages.tiledb
  • python38Packages.qiskit
  • python38Packages.qiskit-aer
  • python38Packages.qiskit-aqua
  • python38Packages.qiskit-ignis
  • python38Packages.tiledb
  • spdlog (spdlog_1)
  • spdlog_0
  • tiledb
  • waybar

@SuperSandro2000 SuperSandro2000 merged commit 5fed56d into NixOS:master Jan 23, 2021
@tobim tobim deleted the pkgsStatic/spdlog branch January 23, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants