Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

androidStudioPackages.{stable,beta,canary,dev}: update #110607

Merged
merged 3 commits into from Jan 23, 2021
Merged

androidStudioPackages.{stable,beta,canary,dev}: update #110607

merged 3 commits into from Jan 23, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jan 23, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Jan 23, 2021

Tested building different applications and running on all three versions.

@ghost
Copy link
Author

ghost commented Jan 23, 2021

@primeos

Also, when I combine the commits into one merge request like this, is this merge request title the right format?

Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

Also, when I combine the commits into one merge request like this, is this merge request title the right format?

I don't think we have any official guidelines/recommendations for this case but your format LGTM (similar titles would also be ok; AFAIK anything reasonable that contains "Android Studio" and "update" would be fine).

@primeos primeos merged commit f940eb4 into NixOS:master Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants