Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt515.qtwebengine: update darwin patches #110605

Merged
merged 1 commit into from Feb 2, 2021
Merged

qt515.qtwebengine: update darwin patches #110605

merged 1 commit into from Feb 2, 2021

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jan 23, 2021

A working build seems to further requre SDK 10.14+ and working that
around is not trivial.

Motivation for this change

Record useful progress towards fixing the qt515.qtwebengine on darwin

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl
qt515.qtwebengine: update darwin patches
03ef368 
A working build seems to further requre SDK 10.14+ and working that
around is not trivial.
@veprbl veprbl requested a review from ttuegel as a code owner January 23, 2021 16:51
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: qt/kde labels Jan 23, 2021
@ofborg ofborg bot requested a review from matthewbauer January 23, 2021 17:00
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110605 run on x86_64-darwin 1

13 packages marked as broken and skipped:
  • cq-editor
  • falkon
  • frescobaldi
  • ghostwriter
  • hydrus
  • multibootusb
  • python37Packages.foxdot
  • python37Packages.tumpa
  • python38Packages.foxdot
  • python38Packages.tumpa
  • python39Packages.foxdot
  • python39Packages.tumpa
  • sl1-to-photon
3 packages failed to build and already failed to build on hydra master:
9 packages failed to build and are new build failures:
  • qt514.qtwebengine: log https://termbin.com/z4da
  • (libsForQt514.qtwebengine): log was empty
  • qt514.qtwebview: log was empty
  • (libsForQt514.qtwebview): log was empty
  • qt515.qtwebengine: log https://termbin.com/yjlv
  • (libsForQt515.qtwebengine): log was empty
  • qt515.qtwebview: log was empty
  • (libsForQt515.qtwebview): log was empty
  • python-qt: log was empty
8 packages built:
  • anki
  • qt5.qtwebengine (libsForQt5.qtwebengine ,qt512.qtwebengine)
  • qt5.qtwebview (libsForQt5.qtwebview ,qt512.qtwebview)
  • python37Packages.pyqtwebengine
  • python38Packages.pyqtwebengine
  • python39Packages.pyqtwebengine
  • qutebrowser
  • webmacs

@veprbl veprbl merged commit 6ba1fbd into NixOS:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: qt/kde 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veprbl @SuperSandro2000