Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esphome: 1.15.2 -> 1.15.3 #110609

Merged
merged 1 commit into from Jan 23, 2021
Merged

esphome: 1.15.2 -> 1.15.3 #110609

merged 1 commit into from Jan 23, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@1000101
Copy link
Member

1000101 commented Jan 23, 2021

@GrahamcOfBorg build esphome

@ofborg ofborg bot requested a review from globin January 23, 2021 17:22
1000101
1000101 reviewed Jan 23, 2021
View reviewed changes
pkgs/tools/misc/esphome/default.nix

src = python.pkgs.fetchPypi {
inherit pname version;
sha256 = "1wnmgn0q4n2vp2cdwsc36acsy7c7w5vyxdglii3432mr5drrgcsx";
sha256 = "a75b53e76fb8b4b394eca18fe74f622ca740bc13b7cbc02e6af5f50126b7aa0b";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the shorter base32 hash 02xanwk03xgmd8pc1jxp2fy419rcc97yg3x1xjab7d5qdzkm6nxp instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because long one is also published on PyPI: https://pypi.org/project/esphome/1.15.3/#copy-hash-modal-50b8dc54-eacf-4cd2-90e6-4875d114b8c6

1000101
1000101 approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@1000101 1000101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on real esp8266 - works fine.

@dotlambda dotlambda merged commit fcef64c into NixOS:master Jan 23, 2021
@dotlambda dotlambda deleted the esphome-1.15.3 branch January 23, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1000101 1000101 1000101 approved these changes

@makefu makefu Awaiting requested review from makefu

@mweinelt mweinelt Awaiting requested review from mweinelt mweinelt is a code owner

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dotlambda @1000101