Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnunet: 0.14.0 -> 0.14.1; gnunet-gtk 0.13.1 -> 0.14.0 #110606

Merged
merged 1 commit into from May 1, 2021
Merged

gnunet: 0.14.0 -> 0.14.1; gnunet-gtk 0.13.1 -> 0.14.0 #110606

merged 1 commit into from May 1, 2021

Conversation

fricklerhandwerk
Copy link
Contributor

@fricklerhandwerk fricklerhandwerk commented Jan 23, 2021 •
edited by davidak

Motivation for this change

Otherwise gnunet-setup will not pick up plugins. See:
https://git.gnunet.org/gnunet-gtk.git/tree/README?id=5034ca084258d6653b2986b00167c736a9cd93ed#n19

Fixes #115112

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pstn pstn mentioned this pull request Mar 4, 2021
Closed
@pstn
Copy link
Contributor

pstn commented Mar 4, 2021

Sorry for ignoring this. I wasn't pinged, somehow. I'll have a look at it this weekend.

@davidak
Copy link
Member

davidak commented Mar 6, 2021 •
edited

Result of nixpkgs-review pr 110606 run on x86_64-linux 1

1 package failed to build:
  • gnunet-gtk
builder for '/nix/store/667363vfiydw8wnw4p6ny3q74wva26sh-gnunet-gtk-0.13.1.drv' failed with exit code 1; last 10 log lines:
  checking GLADE_LIBS... -L/nix/store/j4sgvd6fpcj0i0b54g9k745gg6i06pil-glade-3.38.2/lib -L/nix/store/nb9dx0v21kmp6xhhjqwsdd1gw11my7pq-gtk+3-3.24.24/lib -L/nix/store/1y7vdq6pdj73aqf63jh9ixblas8inklw-atk-2.36.0/lib -L/nix/store/bqgh27q7fhkavvn7jf7gmyy084n5xgy2-glib-2.66.4/lib -L/nix/store/pcqjic85gc9vs4k9vrl8sqskmz4av2pr-cairo-1.16.0/lib -L/nix/store/2hms6sdg0b05y4ag361yxhfm9cpiapk4-gdk-pixbuf-2.42.2/lib -L/nix/store/54j1pgrcxb9qb2xlqn1dlswqrixjbll0-pango-1.47.0/lib -L/nix/store/jj9q6laz6f3k2znqbssdyilp6zlqw0ry-harfbuzz-2.7.4/lib -lgladeui-2 -Wl,--export-dynamic -lgmodule-2.0 -pthread -lgtk-3 -lgdk-3 -lz -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0
  checking for gnutls... --with-gnutls not specified
  checking gnutls/abstract.h usability... yes
  checking gnutls/abstract.h presence... yes
  checking for gnutls/abstract.h... yes
  checking for gnutls_pubkey_import in -lgnutls... yes
  checking for GNUnet core... /nix/store/aawda90f2iv5x0dxp3ag74i37bclwc80-gnunet-0.14.0
  checking for GNUnet util library in /nix/store/00nvvlmfbykdb63p8i22irga55yiqvxy-gnunet-gtk-0.13.1... checking for gnunet/gnunet_util_lib.h... no
  checking for gnunet/gnunet_conversation_service.h... no
  configure: error: gnunet-gtk requires GNUnet
cannot build derivation '/nix/store/3srcxs8cawxjxfdxsv54qhjnxgvbpsj6-env.drv': 1 dependencies couldn't be built
error: --- Error ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ nix
build of '/nix/store/3srcxs8cawxjxfdxsv54qhjnxgvbpsj6-env.drv' failed

@SuperSandro2000
Copy link
Member

ping @fricklerhandwerk

@fricklerhandwerk
Copy link
Contributor Author

fricklerhandwerk commented Mar 21, 2021 via email

@fricklerhandwerk
Copy link
Contributor Author

@SuperSandro2000 @davidak Weird, I cannot reproduce with nixpkgs-review. Was already surprized there was a failure at all, because it built and ran locally in sandbox mode.

@davidak
Copy link
Member

davidak commented Mar 24, 2021

Result of nixpkgs-review pr 110606 run on x86_64-linux 1

1 package marked as broken and skipped:
  • gnunet-gtk

@davidak
Copy link
Member

davidak commented Mar 24, 2021

@fricklerhandwerk the PR didn't change since january, but master did. So that might be the reason why it fails now.

Can you rebase and test again?

@fricklerhandwerk
Copy link
Contributor Author

gnunet upstream seems to have added a dependency to libsodium, therefore configure check failed - it tried to compile the header.

@fricklerhandwerk
Copy link
Contributor Author

@davidak @SuperSandro2000 All good now?

@SuperSandro2000
Copy link
Member 

_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0
       > checking for gnutls... --with-gnutls not specified
       > checking gnutls/abstract.h usability... yes
       > checking gnutls/abstract.h presence... yes
       > checking for gnutls/abstract.h... yes
       > checking for gnutls_pubkey_import in -lgnutls... yes
       > checking for GNUnet core... /nix/store/7nccbpwifxivnjvd26p5p1i1rky92zdf-gnunet-0.14.0
       > checking for GNUnet util library in /nix/store/gal466zyk6zxlrv7c3jwmj5p504dj72v-gnunet-gtk-0.13.1... checking for gnunet/gnunet_util_lib.h... no
       > checking for gnunet/gnunet_conversation_service.h... no
       > configure: error: gnunet-gtk requires GNUnet
       For full logs, run 'nix log /nix/store/0xm6h4jb6jv3hwchchrab9hbc0ac1wgc-gnunet-gtk-0.13.1.drv'.

@fricklerhandwerk
gnunet-gtk: fix build
76d733b 
gnunet: 0.14.0 -> 0.14.1

gnunet-gtk: 0.13.1 -> 0.14.0 (there is no 0.14.1 release)

build with correct `gnunet` location. otherwise `gnunet-setup` will not pick up plugins. See:
https://git.gnunet.org/gnunet-gtk.git/tree/README?id=5034ca084258d6653b2986b00167c736a9cd93ed#n19

add libsodium to pass configure check for GNUnet util library.
@fricklerhandwerk
Copy link
Contributor Author

fricklerhandwerk commented Apr 14, 2021 •
edited

Oh my, this is so embarrassing. Sorry for wasting your time. What the hell, where did my force-pushed change go? It even disappeared from my development machine, nothing in git reflog either, only the updated commit message was correct. Please check again, for me nixpkgs-review pr 110606 was successful.

@SuperSandro2000 SuperSandro2000 changed the title gnunet-gtk: build with correct gnunet location gnunet: 0.14.0 -> 0.14.1; gnunet-gtk 0.13.1 -> 0.14.0 Apr 15, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110606 run on x86_64-linux 1

2 packages built:
  • gnunet
  • gnunet-gtk

SuperSandro2000
SuperSandro2000 reviewed Apr 15, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

gnunet: Ask if output path include (1.6M) could be split with outputs = [ ... "dev" ];
gnunet: Ask if output path lib (7.5M) could be split with outputs = [ ... "lib" ];
gnunet: Ask if output path share/info (2.1M) could be split with outputs = [ ... "info" ];

@fricklerhandwerk
Copy link
Contributor Author

@SuperSandro2000 I'll note to do it first thing next time I touch this. Right now I would like this to get merged, as refactoring will be more work for everyone without much immediate benefit.

@davidak
Copy link
Member

davidak commented May 1, 2021

Result of nixpkgs-review pr 110606 run on x86_64-linux 1

2 packages built:
  • gnunet
  • gnunet-gtk

davidak
davidak approved these changes May 1, 2021
View reviewed changes
Copy link
Member

@davidak davidak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating and fixing it!

Builds and binaries seem to work (i will create separate issues for minor issues)

@davidak davidak merged commit 2aa1333 into NixOS:master May 1, 2021
This was referenced May 1, 2021
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@davidak davidak davidak approved these changes

@vrthra vrthra Awaiting requested review from vrthra

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gnunet-gtk fail to build
4 participants
@fricklerhandwerk @pstn @davidak @SuperSandro2000