Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvmPackages_11: 11.0.1 -> 11.1.0 #110631

Merged
merged 2 commits into from Feb 18, 2021
Merged

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Jan 23, 2021

Motivation for this change

https://github.com/llvm/llvm-project/releases/tag/llvmorg-11.1.0
https://lists.llvm.org/pipermail/release-testers/2021-February/001472.html
https://lists.llvm.org/pipermail/release-testers/2021-January/001466.html
https://lists.llvm.org/pipermail/release-testers/2021-January/001457.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ggreif
Copy link
Contributor Author

ggreif commented Jan 23, 2021

@GrahamcOfBorg build llvmPackages_11

pkgs/development/compilers/llvm/10/openmp.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/llvm/5/openmp.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/llvm/6/openmp.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/llvm/8/openmp.nix Outdated Show resolved Hide resolved
pkgs/development/compilers/llvm/9/openmp.nix Outdated Show resolved Hide resolved
@bobrik
Copy link
Contributor

bobrik commented Feb 17, 2021

11.1.0 is out now

@bobrik
Copy link
Contributor

bobrik commented Feb 17, 2021

Don't you need to update the checksums as well?

@ggreif
Copy link
Contributor Author

ggreif commented Feb 17, 2021

@bobrik Sure, my Mac needs to build a lot. Patience!

@ggreif ggreif changed the title llvmPackages_11: 11.0.1 -> 11.1.0rc2 llvmPackages_11: 11.0.1 -> 11.1.0 Feb 17, 2021
@SuperSandro2000
Copy link
Member

@ofborg eval

🤔

Automatic merge went well; stopped before committing as requested
error: --- TypeError ------------------------------------------------------------------------------------------------------------------------------------------------------------------- nixat: (12:35) in file: /nix/store/lhz31hg5xsz65acfi2a47kv05gyd36dx-nixpkgs-review/lib/python3.8/site-packages/nixpkgs_review/nix/evalAttrs.nix

    11|     pkg = lib.attrByPath attrPath null pkgs;
    12|     maybePath = builtins.tryEval "${pkg}";
      |                                   ^
    13|   in rec {

cannot coerce a set to a string

@ggreif
Copy link
Contributor Author

ggreif commented Feb 18, 2021

@SuperSandro2000 Sorry, that doesn't ring a bell...
@bobrik Unfortunately this laptop doesn't quite build staging, so I am a bit lost with the rest of the hashes. Feel free to build on this. Also why do the aarch64 builders present hash mismatches in a base64-like way and intel ones in a base32 style?

I should have them all now.

@SuperSandro2000
Copy link
Member

Unfortunately this laptop doesn't quite build staging, so I am a bit lost with the rest of the hashes. Feel free to build on this. Also why do the aarch64 builders present hash mismatches in a base64-like way and intel ones in a base32 style?

If you can list the packages I should build I can check if there are more has mismatches.

@primeos
Copy link
Member

primeos commented Feb 18, 2021

@bobrik Unfortunately this laptop doesn't quite build staging, so I am a bit lost with the rest of the hashes.

It should usually be fine if you test this on e.g. the current nixos-unstable channel revision ;)

I should have them all now.

LGTM as well :) Thanks!

If you can list the packages I should build I can check if there are more has mismatches.

Good idea. I've just posted my silly script here in case anyone ever needs to verify the hashes again: #100725 (comment)

Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff LGTM and llvmPackages_11 on x86_64-linux — Success (CI) so this should be good to go :)

@primeos primeos marked this pull request as ready for review February 18, 2021 13:02
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110631 run on x86_64-linux 1

2 packages built:
  • git
  • nixUnstable

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

git:

gpl2 is a deprecated license, check if project uses gpl2Plus or gpl2Only and change meta.license accordingly.

Near pkgs/applications/version-management/git-and-tools/git/default.nix:339:5:

    |
339 |     license = lib.licenses.gpl2;
    |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/unclear-gpl.md
makeWrapper is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/applications/version-management/git-and-tools/git/default.nix:73:3:

   |
73 |   buildInputs = [curl openssl zlib expat cpio makeWrapper libiconv]
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
perl is a build tool so it likely goes to nativeBuildInputs, not buildInputs.

Near pkgs/applications/version-management/git-and-tools/git/default.nix:73:3:

   |
73 |   buildInputs = [curl openssl zlib expat cpio makeWrapper libiconv]
   |   ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/build-tools-in-build-inputs.md
Unused argument: fetchpatch.
Near pkgs/applications/version-management/git-and-tools/git/default.nix:2:3:

  |
2 | , fetchpatch
  |   ^
nixUnstable:

Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/tools/package-management/nix/default.nix:66:17:

   |
66 |                 ./aws-sdk-cpp-TransferManager-ContentEncoding.patch
   |                 ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md
Please add a comment on the line above, explaining the purpose of this patch.
Near pkgs/tools/package-management/nix/default.nix:203:16:

    |
203 |     patches = [(
    |                ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/missing-patch-comment.md

@SuperSandro2000 SuperSandro2000 merged commit 6231ed4 into NixOS:staging Feb 18, 2021
@ggreif ggreif deleted the llvm-11.1 branch February 18, 2021 23:55
@bobrik bobrik mentioned this pull request Feb 19, 2021
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants