Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2instanceconnectcli: init at 1.0.2 #110629

Merged
merged 1 commit into from Jan 26, 2021
Merged

ec2instanceconnectcli: init at 1.0.2 #110629

merged 1 commit into from Jan 26, 2021

Conversation

yurrriq
Copy link
Member

@yurrriq yurrriq commented Jan 23, 2021 •
edited

Motivation for this change

Add ec2instanceconnectcli.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yurrriq
Copy link
Member Author

yurrriq commented Jan 23, 2021

@GrahamcOfBorg build ec2instanceconnectcli

@yurrriq
Copy link
Member Author

yurrriq commented Jan 23, 2021

N.B. I'll want to test this on my work computer before marking it ready for review. I've been using a similar expression for 1.0.0 for some time.

@yurrriq yurrriq marked this pull request as ready for review January 25, 2021 16:22
@yurrriq yurrriq requested a review from FRidh as a code owner January 25, 2021 16:22
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110629 run on x86_64-darwin 1

3 packages built:
  • ec2instanceconnectcli (python38Packages.ec2instanceconnectcli)
  • python37Packages.ec2instanceconnectcli
  • python39Packages.ec2instanceconnectcli

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

ec2instanceconnectcli:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
python37Packages.ec2instanceconnectcli:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
python39Packages.ec2instanceconnectcli:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110629 run on x86_64-linux 1

3 packages built:
  • ec2instanceconnectcli (python38Packages.ec2instanceconnectcli)
  • python37Packages.ec2instanceconnectcli
  • python39Packages.ec2instanceconnectcli

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

ec2instanceconnectcli:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
python37Packages.ec2instanceconnectcli:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
python39Packages.ec2instanceconnectcli:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

@yurrriq yurrriq force-pushed the add-ec2instanceconnectcli branch 2 times, most recently from ff6b040 to e9b40a6 Compare January 25, 2021 21:30
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110629 run on x86_64-darwin 1

3 packages built:
  • python37Packages.ec2instanceconnectcli
  • python38Packages.ec2instanceconnectcli
  • python39Packages.ec2instanceconnectcli

@yurrriq @SuperSandro2000
ec2instanceconnectcli: init at 1.0.2
264d47e 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110629 run on x86_64-linux 1

3 packages built:
  • python37Packages.ec2instanceconnectcli
  • python38Packages.ec2instanceconnectcli
  • python39Packages.ec2instanceconnectcli

@SuperSandro2000 SuperSandro2000 merged commit 4a2db77 into NixOS:master Jan 26, 2021
@yurrriq
Copy link
Member Author

yurrriq commented Jan 26, 2021

Thanks!

@yurrriq yurrriq deleted the add-ec2instanceconnectcli branch January 26, 2021 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yurrriq @SuperSandro2000 @jonringer