Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] samba: 4.12.6 -> 4.12.11 #110638

Merged
merged 1 commit into from Jan 25, 2021
Merged

[20.09] samba: 4.12.6 -> 4.12.11 #110638

merged 1 commit into from Jan 25, 2021

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Jan 23, 2021 •
edited

Motivation for this change

fixes #106235, fixes #102896, and fixes #99848

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from bachp January 23, 2021 22:13
@dotlambda dotlambda mentioned this pull request Jan 23, 2021
Merged
10 tasks
@ofborg ofborg bot requested a review from aneeshusa January 23, 2021 22:23
@dasJ
Copy link
Member

dasJ commented Jan 25, 2021

Did not test but the code looks good. Samba has proven great backwards compatiblity (I switched from 4.12 to 4.13 without any manual steps) so I guess this won't break anything

@dotlambda
Copy link
Member Author

@ofborg test samba

@dotlambda dotlambda merged commit 03207b8 into NixOS:release-20.09 Jan 25, 2021
@dotlambda dotlambda deleted the samba-4.12.11 branch January 25, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bachp bachp Awaiting requested review from bachp

@aneeshusa aneeshusa Awaiting requested review from aneeshusa

@dasJ dasJ Awaiting requested review from dasJ

@doronbehar doronbehar Awaiting requested review from doronbehar

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dotlambda @dasJ