Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hindsight: init at 2021.01.16 #110620

Closed
wants to merge 1 commit into from
Closed

hindsight: init at 2021.01.16 #110620

wants to merge 1 commit into from

Conversation

ryneeverett
Copy link
Contributor

Motivation for this change

Web browser forensics for Google Chrome/Chromium

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 requested changes Jan 23, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the contributing guide more closely.

pkgs/development/node-packages/composition.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/puremagic/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/puremagic/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/xlsx2html/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/xlsx2html/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/hindsight/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/hindsight/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/hindsight/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/hindsight/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/hindsight/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 marked this pull request as draft January 23, 2021 19:26
@ryneeverett
Copy link
Contributor Author

Please follow the contributing guide more closely.

What document are you referring to?

@SuperSandro2000
Copy link
Member

Please follow the contributing guide more closely.

What document are you referring to?

https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/python.section.md and https://github.com/NixOS/nixpkgs/tree/master/doc/contributing

jonringer
jonringer reviewed Jan 24, 2021
View reviewed changes
pkgs/development/node-packages/node-env.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/puremagic/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/xlsx2html/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/development/tools/hindsight/default.nix Outdated Show resolved Hide resolved
@ryneeverett ryneeverett force-pushed the hindsight-init branch 2 times, most recently from 86c3f76 to 2f8e563 Compare January 24, 2021 07:10
@ofborg ofborg bot requested a review from midchildan January 24, 2021 07:19
@ryneeverett ryneeverett marked this pull request as ready for review January 24, 2021 08:14
@SuperSandro2000
Copy link
Member

I am going to block this until #110394 is merged.

@raboof
Copy link
Member

raboof commented Jan 25, 2021

I am going to block this until #110394 is merged.

#110545 was just merged instead

@stale
Copy link

stale bot commented Jul 26, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 26, 2021
@ryneeverett ryneeverett mentioned this pull request Jul 12, 2022
Open
@SuperSandro2000
Copy link
Member

Closing due to inactivity from author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

@midchildan midchildan Awaiting requested review from midchildan

Assignees
No one assigned
Labels
2.status: blocked by pr/issue 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ryneeverett @SuperSandro2000 @raboof @jonringer