Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crawl: 0.25.1 -> 0.26.0 #110566

Merged
merged 1 commit into from Jan 23, 2021
Merged

crawl: 0.25.1 -> 0.26.0 #110566

merged 1 commit into from Jan 23, 2021

Conversation

catern
Copy link
Contributor

@catern catern commented Jan 23, 2021 •
edited

Motivation for this change

crawl: 0.25.1 -> 0.26.0

FORCE_PKGCONFIG was added upstream in crawl/crawl@61de54256c8, so we
can drop our patch to the Makefile which does the same thing - nice!
Still need the other patches since crawl/crawl#1367 isn't yet fully
merged.

I haven't tested building on MacOS - changing to FORCE_PKGCONFIG will affect the MacOS build, so can someone do that?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@catern
crawl: 0.25.1 -> 0.26.0
0bdc35a 
FORCE_PKGCONFIG was added upstream in crawl/crawl@61de54256c8, so we
can drop our patch to the Makefile which does the same thing - nice!
Still need the other patches since crawl/crawl#1367 isn't yet fully
merged.
@ofborg ofborg bot requested a review from abbradar January 23, 2021 05:45
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110566 run on x86_64-linux 1

2 packages built:
  • crawl
  • crawlTiles

@SuperSandro2000 SuperSandro2000 merged commit 4317c59 into NixOS:master Jan 23, 2021
@catern
Copy link
Contributor Author

catern commented Jan 27, 2021

Note crawl/crawl#1225 - upgrading users will have to manually delete ~/.crawl/des

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@catern @SuperSandro2000