Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cypress: add updateScript #110562

Merged
merged 1 commit into from May 2, 2021
Merged

cypress: add updateScript #110562

merged 1 commit into from May 2, 2021

Conversation

r-k-b
Copy link
Contributor

@r-k-b r-k-b commented Jan 23, 2021

Motivation for this change

To keep Cypress up-to-date.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

hugolgst
hugolgst approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@hugolgst hugolgst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolaente
Copy link
Member

Since there now is cypress 7.0 in master, could you rebase your pr to only contain the update script?

@SuperSandro2000
Copy link
Member

7.1.0 is already on master. Please rebase this PR and only leave the remaining changes.

@kolaente
Copy link
Member

Now there's 7.2.0: #120844

@r-k-b r-k-b changed the title cypress: 6.0.0 -> 6.3.0 and add updateScript cypress: add updateScript May 2, 2021
@SuperSandro2000 SuperSandro2000 merged commit df3c94e into NixOS:master May 2, 2021
@r-k-b r-k-b deleted the cypress/updateScript branch May 3, 2021 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@kolaente kolaente kolaente approved these changes

@hugolgst hugolgst hugolgst approved these changes

@thorstenweber83 thorstenweber83 Awaiting requested review from thorstenweber83

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@r-k-b @kolaente @SuperSandro2000 @hugolgst