Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.gradient: build fix #110565

Merged
merged 6 commits into from Feb 1, 2021
Merged

python3Packages.gradient: build fix #110565

merged 6 commits into from Feb 1, 2021

Conversation

urbas
Copy link
Contributor

@urbas urbas commented Jan 23, 2021 •
edited

Motivation for this change

The main motivation was to fix this failing build.

I think these are the minimal changes to fix the build. It's a bit concerning that so many new packages and so much renaming had to be done to fix this.

@freezeboy: Shall we just remove the old gradient-sdk and paperspace packages instead of adding all of these new packages? No other package depends on them, so removal should be easy.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@urbas urbas requested a review from freezeboy January 23, 2021 04:41
@ofborg ofborg bot requested a review from thoughtpolice January 23, 2021 04:50
@freezeboy
Copy link
Contributor

I am ok with removing the old packages that were broken iirc btw.

I can't remember why it took so long and as i am on travel i can't check right now.

@urbas urbas mentioned this pull request Jan 23, 2021
Closed
10 tasks
@urbas
Copy link
Contributor Author

urbas commented Jan 23, 2021

I am ok with removing the old packages that were broken iirc btw.

Awesome, here's the pull request for the removal: #110576

I can't remember why it took so long and as i am on travel i can't check right now.

No worries, I'll leave this pull request open until we decide whether to remove or keep these packages.

@urbas urbas changed the title Gradient sdk renamed python3Packages.gradient: build fix Jan 23, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110565 run on x86_64-linux 1

15 packages built:
  • python37Packages.gradient
  • python37Packages.gradient-utils
  • python37Packages.halo
  • python37Packages.log-symbols
  • python37Packages.spinners
  • python38Packages.gradient
  • python38Packages.gradient-utils
  • python38Packages.halo
  • python38Packages.log-symbols
  • python38Packages.spinners
  • python39Packages.gradient
  • python39Packages.gradient-utils
  • python39Packages.halo
  • python39Packages.log-symbols
  • python39Packages.spinners

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.gradient-utils:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
python38Packages.gradient-utils:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
python39Packages.gradient-utils:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

@urbas
Copy link
Contributor Author

urbas commented Jan 23, 2021

@SuperSandro2000 @jonringer: before I address the comments:

Shall we rather remove the packages (by merging #110576) instead of adding all these new packages (by merging this PR)?

@SuperSandro2000
Copy link
Member

Shall we rather remove the packages (by merging #110576) instead of adding all these new packages (by merging this PR)?

Adding 3 packages is in the grand scheme of nixpkgs nothing to worry about. If the package is useful we can keep it. Is there any other reason to remove it?

@urbas
Copy link
Contributor Author

urbas commented Jan 23, 2021

Great, no reason (I was just worried about how this simple fix blew up a bit).

Anyway, I'll go ahead with this PR and close the other one. 👍

@jonringer
Copy link
Contributor

Is there any other reason to remove it?

every package is a small maintenance burden. I would just leave a comment near pname stating that it's no longer strictly needed, and can be safely removed.

If it can be maintained through nixpkgs-update (the bot), then I'm fine with keeping it around.

@urbas
Copy link
Contributor Author

urbas commented Jan 24, 2021

@SuperSandro2000: adding tests will be a significant undertaking. I have refrained from adding them to keep the PR small. Let me know if I should still go ahead and add tests.

Other than that the PR is ready to go.

@SuperSandro2000
Copy link
Member

@SuperSandro2000: adding tests will be a significant undertaking. I have refrained from adding them to keep the PR small. Let me know if I should still go ahead and add tests.

Other than that the PR is ready to go.

It would be nice to have more testing but it is not a hard requirement.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110565 run on x86_64-darwin 1

15 packages built:
  • python37Packages.gradient
  • python37Packages.gradient-utils
  • python37Packages.halo
  • python37Packages.log-symbols
  • python37Packages.spinners
  • python38Packages.gradient
  • python38Packages.gradient-utils
  • python38Packages.halo
  • python38Packages.log-symbols
  • python38Packages.spinners
  • python39Packages.gradient
  • python39Packages.gradient-utils
  • python39Packages.halo
  • python39Packages.log-symbols
  • python39Packages.spinners

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.gradient-utils:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
python38Packages.gradient-utils:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
python39Packages.gradient-utils:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110565 run on x86_64-linux 1

15 packages built:
  • python37Packages.gradient
  • python37Packages.gradient-utils
  • python37Packages.halo
  • python37Packages.log-symbols
  • python37Packages.spinners
  • python38Packages.gradient
  • python38Packages.gradient-utils
  • python38Packages.halo
  • python38Packages.log-symbols
  • python38Packages.spinners
  • python39Packages.gradient
  • python39Packages.gradient-utils
  • python39Packages.halo
  • python39Packages.log-symbols
  • python39Packages.spinners

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.gradient-utils:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
python38Packages.gradient-utils:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
python39Packages.gradient-utils:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

@urbas
Copy link
Contributor Author

urbas commented Jan 31, 2021

@SuperSandro2000: I added tests where I could (gradient-utils) and documented why I couldn't add tests to the rest.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110565 run on x86_64-linux 1

13 packages built:
  • python37Packages.gradient
  • python37Packages.gradient-utils
  • python37Packages.halo
  • python37Packages.log-symbols
  • python37Packages.spinners
  • python38Packages.gradient
  • python38Packages.gradient-utils
  • python38Packages.halo
  • python38Packages.log-symbols
  • python38Packages.spinners
  • python39Packages.halo
  • python39Packages.log-symbols
  • python39Packages.spinners

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110565 run on x86_64-darwin 1

15 packages built:
  • python37Packages.gradient
  • python37Packages.gradient-utils
  • python37Packages.halo
  • python37Packages.log-symbols
  • python37Packages.spinners
  • python38Packages.gradient
  • python38Packages.gradient-utils
  • python38Packages.halo
  • python38Packages.log-symbols
  • python38Packages.spinners
  • python39Packages.gradient
  • python39Packages.gradient-utils
  • python39Packages.halo
  • python39Packages.log-symbols
  • python39Packages.spinners

@SuperSandro2000 SuperSandro2000 merged commit 7b7556a into NixOS:master Feb 1, 2021
@urbas urbas deleted the gradient-sdk-renamed branch February 1, 2021 19:40
@oxzi oxzi mentioned this pull request Feb 8, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@freezeboy freezeboy Awaiting requested review from freezeboy

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urbas @freezeboy @SuperSandro2000 @jonringer