Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.{gradient_sdk,paperspace}: removed #110576

Closed
wants to merge 2 commits into from

Conversation

urbas
Copy link
Contributor

@urbas urbas commented Jan 23, 2021

Motivation for this change

The python3Packages.gradient_sdk package is broken. The main motivation is to fix the build. However, this package is no longer maintained at PyPI (the project has been renamed and moved to a different repository).

This change also removes python3Packages.paperspace (which depends on gradient_sdk). This package has also been renamed in PyPI and moved to a different repository.

This pull request is an alternative to #110565

Things done

nix-review wip output:

6 packages removed:
python3.7-gradient_sdk (†0.0.4) python3.7-paperspace (†0.2.0) python3.8-gradient_sdk (†0.0.4) python3.8-paperspace (†0.2.0) python3.9-gradient_sdk (†0.0.4) python3.9-paperspace (†0.2.0)
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@urbas urbas mentioned this pull request Jan 23, 2021
10 tasks
@urbas urbas changed the title python3Packages.gradient_sdk removed python3Packages.{gradient_sdk,paperspace} removed Jan 23, 2021
@urbas urbas changed the title python3Packages.{gradient_sdk,paperspace} removed python3Packages.{gradient_sdk,paperspace}: removed Jan 23, 2021
@freezeboy
Copy link
Contributor

LGTM

@urbas
Copy link
Contributor Author

urbas commented Jan 23, 2021

We decided to go ahead with #110565 (keep these packages) and abandon this PR.

@urbas urbas closed this Jan 23, 2021
@urbas urbas deleted the gradient-removed branch January 23, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants