Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm_{5,6,8..11}: fix missing lib from stdenv.lib -> lib #110643

Merged
merged 4 commits into from Jan 24, 2021
Merged

llvm_{5,6,8..11}: fix missing lib from stdenv.lib -> lib #110643

merged 4 commits into from Jan 24, 2021

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Jan 23, 2021 •
edited

this was a fallout of the stdenv.lib -> lib changes

actually llvm/7/ was fixed already.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ggreif
llvm_{5..11}: explicitly pass lib to openmp.nix
8675e2f 
this was a fallout of the stdenv.lib -> lib changes
@ggreif
Copy link
Contributor Author

ggreif commented Jan 23, 2021 •
edited

@GrahamcOfBorg build llvmPackages_11 llvmPackages_10 llvmPackages_9 llvmPackages_8 llvmPackages_7 llvmPackages_6 llvmPackages_5

@ggreif ggreif changed the title llvm_{5..11}: explicitly pass lib to openmp.nix llvm_{5,6,8..11}: explicitly pass lib to openmp.nix Jan 23, 2021
@ggreif
Copy link
Contributor Author

ggreif commented Jan 23, 2021 •
edited

@SuperSandro2000 this is the PR against master, I'll apply your suggestions here (from #110631).

ggreif and others added 2 commits January 24, 2021 00:46
@ggreif @SuperSandro2000
Apply suggestions from code review
84b974a 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@ggreif
tweak
2628680
@ggreif
Copy link
Contributor Author

ggreif commented Jan 23, 2021

@SuperSandro2000 PTAL

@SuperSandro2000 SuperSandro2000 changed the title llvm_{5,6,8..11}: explicitly pass lib to openmp.nix llvm_{5,6,8..11}: fix missing lib from stdenv.lib -> lib Jan 24, 2021
@SuperSandro2000 SuperSandro2000 merged commit 5105bf4 into NixOS:master Jan 24, 2021
@ggreif ggreif deleted the openmp-fix branch January 24, 2021 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ggreif @SuperSandro2000