Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins: updates #110644

Merged
merged 4 commits into from Jan 24, 2021
Merged

vimPlugins: updates #110644

merged 4 commits into from Jan 24, 2021

Conversation

teto
Copy link
Member

@teto teto commented Jan 23, 2021

Motivation for this change

packer.nvim is getting increasingly popular in neovim, especially because it can deal with plugin dependency via luarocks.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AndersonTorres
Copy link
Member

Was it autogenerated?

@teto
Copy link
Member Author

teto commented Jan 23, 2021

yes it was, I've just added sqlite as a buildInput of sql.nvim

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next time please update before doing any changes then do your changes and update again. This makes reviewing the changes way easier.

@teto
Copy link
Member Author

teto commented Jan 24, 2021

@SuperSandro2000 I dont get your comment, this is all generated as recommended by:
pkgs/misc/vim-plugins/update.py --add tami5/sql.nvim --add nvim-telescope/telescope-frecency.nvim --add wbthomason/packer.nvim
Checking out changes commit by commit is quite straightforward.

@SuperSandro2000
Copy link
Member

@SuperSandro2000 I dont get your comment, this is all generated as recommended by:
pkgs/misc/vim-plugins/update.py --add tami5/sql.nvim --add nvim-telescope/telescope-frecency.nvim --add wbthomason/packer.nvim
Checking out changes commit by commit is quite straightforward.

Next time just run ./pkgs/misc/vim-plugins/update.py before adding the plugins.

@SuperSandro2000 SuperSandro2000 merged commit b9e560c into NixOS:master Jan 24, 2021
@teto teto deleted the add-packer branch January 24, 2021 10:05
@teto
Copy link
Member Author

teto commented Jan 24, 2021

but there is an "update commit" before all of them, that's what the script does...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants