Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pytest_xdist: 2.1.0 -> 2.2.0 #110601

Merged
merged 3 commits into from Feb 1, 2021
Merged

python3Packages.pytest_xdist: 2.1.0 -> 2.2.0 #110601

merged 3 commits into from Feb 1, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda force-pushed the pytest_xdist-2.2.0 branch 2 times, most recently from fdce4d4 to e9da82b Compare January 28, 2021 23:53
@dotlambda
Copy link
Member Author

According to

rg --multiline --multiline-dotall -g "\!pkgs/top-level/python-packages.nix" "pytest_\\d.*?pytest.xdist|pytest.xdist.*?pytest_\\d"

only psautohint is using pytest-xdist as well as a non-standard version of pytest.
I will make it use pytest instead of pytest_5 and then add pytest to pytest_xdist's propagatedBuildInputs.
cc @sternenseemann

@dotlambda
Copy link
Member Author

According to

rg --multiline --multiline-dotall -g "\!pkgs/top-level/python-packages.nix" "pytest_\\d.*?pytest.forked|pytest.forked.*?pytest_\\d"

no expression seems to be using both pytest-forked as well as a non-standard version of pytest.
Adding pytest to pytest-forked's propagatedBuildInputs should thus not be problematic.

@dotlambda
pythonPackages:pytest-forked: run tests
7267c7b 
Also update inputs to match setup.py and add dotlambda to maintainers.
@dotlambda
python3Packages.pytest_xdist: 2.1.0 -> 2.2.0
3d19493 
Also update inputs to match setup.py.
@dotlambda
python3Packages.psautohint: use pytest_6
2aafd59 
We prefer using a single version of pytest within pythonPackages.
@sternenseemann
Copy link
Member

@GrahamcOfBorg build python3Packages.psautohint

@sternenseemann
Copy link
Member

No objections from my side, but I don't know much about the pytest stuff in question.

@SuperSandro2000
Copy link
Member

@jonringer Can you take a look at this? I think it should be good to merge.

@dotlambda dotlambda merged commit 76048fe into NixOS:staging Feb 1, 2021
@dotlambda dotlambda deleted the pytest_xdist-2.2.0 branch February 1, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sternenseemann sternenseemann sternenseemann left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @sternenseemann @SuperSandro2000 @jonringer