Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintainers/teams: add beam team #110623

Merged
merged 2 commits into from Feb 8, 2021
Merged

maintainers/teams: add beam team #110623

merged 2 commits into from Feb 8, 2021

Conversation

yurrriq
Copy link
Member

@yurrriq yurrriq commented Jan 23, 2021

Motivation for this change

Add a beam team to better coordinate maintenance of BEAM-related packages and modules.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@yurrriq yurrriq mentioned this pull request Jan 23, 2021
@yurrriq
Copy link
Member Author

yurrriq commented Jan 23, 2021

So far, I've included maintainers from related packages:

@SuperSandro2000
Copy link
Member

@yurrriq please fix the merge conflict and if we have a positive reaction from everyone mentioned (thumbs up the first post maybe) we can merge this.

@yurrriq
Copy link
Member Author

yurrriq commented Jan 23, 2021

Sorry about that, I've rebased now and added @Br1ght0ne.

@yurrriq
Copy link
Member Author

yurrriq commented Jan 23, 2021

Should we update doc/languages-frameworks/beam.section.md to mention the team?

@SuperSandro2000
Copy link
Member

Should we update doc/languages-frameworks/beam.section.md to mention the team?

Might be a good idea.

@yurrriq
Copy link
Member Author

yurrriq commented Jan 23, 2021

With some cursory grepping, I wasn't able to find any mention of teams in other docs 😕

@SuperSandro2000
Copy link
Member

With some cursory grepping, I wasn't able to find any mention of teams in other docs 😕

I did not check this but if the others don't do it then it is fine without it.

@happysalada
Copy link
Contributor

happysalada commented Jan 23, 2021

@yurrriq thnaks a lot for doing this!

Can you add

  • the gleam compiler?
  • rebar3 build manager
  • rebar build manager (Maybe not necessary, it's deprecated as far as I know and there are no existing maintainers)

When you have a moment

@SuperSandro2000
Copy link
Member

it's deprecated as far as I know and there are no existing maintainers

It would be still good to have some maintainers for it as long as it is in nixpkgs.

@Havvy
Copy link
Contributor

Havvy commented Jan 24, 2021

My name should be removed from anywhere I'm mentioned, but you should definitely NOT create a new team of people without asking for their permission.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 24, 2021

My name should be removed from anywhere I'm mentioned, but you should definitely NOT create a new team of people without asking for their permission.

We can't purge logs and activity on GitHub. It is pretty normal to collect people who updated packages and where written as maintainer in a team and ask then for their permission to not miss anyone. Before merging we wait until their responses and remove anyone who does not want to be part of the team.

@DianaOlympos
Copy link
Contributor

If you need one more maintainer, feel free to add me. I have been doing quite some work around the beam set recently

@happysalada
Copy link
Contributor

@yurrriq how about proceeding the other way around. Just adding people who have reacted.
so far I can see @Br1ght0ne, yourself, @DianaOlympos and me.
Let's keep it at that for now, people can always add themselves later on.
If we wait for everybody's approval we might struggle to merge this.
I don't think anyone who doesn't respond within a week will mind being taken off the maintainer's list of a package.

@yurrriq
Copy link
Member Author

yurrriq commented Jan 25, 2021

My intention was for this Draft PR to start these discussions regarding desired team members. Part of the reason it's marked as a draft is to ensure we don't make any changes without consent and buy-in from all involved. I figured it was better to have something tangible to discuss.

To be clear for those that have requested to be removed, as this PR exists currently, that would also remove you as maintainers of the specific BEAM packages. Is that the desired effect?

@yurrriq
Copy link
Member Author

yurrriq commented Jan 25, 2021

I've force pushed the following updates:

  • Change the BEAM team members list to those who have actively expressed interest
  • Set maintainers = lib.teams.beam.members on a few more BEAM-related expressions
    • Notably, this additionally removes @tazjin from pkgs/development/interpreters/elixir/generic-builder.nix
    • I notice the pgsql, webdriver, and hex packages currently have @ericbmerritt as the sole maintainer.
  1. Should we set maintainers = lib.teams.beam.members for pgsql, webdriver, and hex packages too?
  2. Would you like to be included in the BEAM team, @tazjin?
  3. Would you like to be included in the BEAM team, @ericbmerritt?

@yurrriq
Copy link
Member Author

yurrriq commented Jan 25, 2021

If you need one more maintainer, feel free to add me. I have been doing quite some work around the beam set recently

@DianaOlympos, it looks like we'll need to add you to maintainers/maintainer-list.nix. I can do that now for convenience, otherwise feel free to PR against yurrriq/nixpkgs@beam-team.

@ankhers
Copy link
Contributor

ankhers commented Jan 25, 2021

I am fine with being added to this list with the caveat that I do not currently have a lot of time, at least until this virus clears up a little more in my area.

@happysalada
Copy link
Contributor

@yurrriq I would say yes to setting the beam team for pgsql, webdriver and hex.

@tazjin
Copy link
Member

tazjin commented Jan 26, 2021

@yurrriq Thanks for asking, unfortunately I don't have time for this at the moment (and - again unfortunately - I'm not using any BEAM languages for the time being :))

@yurrriq
Copy link
Member Author

yurrriq commented Jan 26, 2021

@yurrriq I would say yes to setting the beam team for pgsql, webdriver and hex.

Done. As I see it, we're waiting on feedback from Eric Merritt and Thomas Depierre before marking this ready for broader review.

@happysalada
Copy link
Contributor

@yurrriq @SuperSandro2000
it looks like @ericbmerritt is busy. How about we merge this for now, we can always make a new PR later?
Let me know if you think this is premature.

@yurrriq
Copy link
Member Author

yurrriq commented Feb 1, 2021

Looks like his last contribution was in 2016, so that seems fair to me.

@yurrriq yurrriq marked this pull request as ready for review February 1, 2021 15:49
@gleber
Copy link
Contributor

gleber commented Feb 2, 2021

I do not have much time for BEAM in Nixpkgs lately. I can not promise swift response, so If you need backup people on the list, feel free to include me.

@happysalada
Copy link
Contributor

@SuperSandro2000 when you have a moment, please take a look. No problem if you are busy.

@Mic92
Copy link
Member

Mic92 commented Feb 7, 2021

is the list complete now?

@happysalada
Copy link
Contributor

@Mic92 yes that is my understanding.

@yurrriq
Copy link
Member Author

yurrriq commented Feb 8, 2021

I'd say it's complete for now anyway.

@Mic92 Mic92 merged commit c538a83 into NixOS:master Feb 8, 2021
@Mic92
Copy link
Member

Mic92 commented Feb 8, 2021

I could not invite @DianaOlympos to https://github.com/orgs/NixOS/teams/beam, because he is not in the nixos organisation yet.

@DianaOlympos
Copy link
Contributor

@Mic92 i am in now

@Mic92
Copy link
Member

Mic92 commented Feb 8, 2021

fixed.

@yurrriq
Copy link
Member Author

yurrriq commented Feb 10, 2021

Thanks, @Mic92 and @DianaOlympos!

@yurrriq yurrriq deleted the beam-team branch February 10, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants