New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maintainers/teams: add beam team #110623
maintainers/teams: add beam team #110623
Conversation
So far, I've included maintainers from related packages: |
@yurrriq please fix the merge conflict and if we have a positive reaction from everyone mentioned (thumbs up the first post maybe) we can merge this. |
Sorry about that, I've rebased now and added @Br1ght0ne. |
Should we update doc/languages-frameworks/beam.section.md to mention the team? |
Might be a good idea. |
With some cursory grepping, I wasn't able to find any mention of teams in other docs 😕 |
I did not check this but if the others don't do it then it is fine without it. |
@yurrriq thnaks a lot for doing this! Can you add
When you have a moment |
It would be still good to have some maintainers for it as long as it is in nixpkgs. |
My name should be removed from anywhere I'm mentioned, but you should definitely NOT create a new team of people without asking for their permission. |
We can't purge logs and activity on GitHub. It is pretty normal to collect people who updated packages and where written as maintainer in a team and ask then for their permission to not miss anyone. Before merging we wait until their responses and remove anyone who does not want to be part of the team. |
If you need one more maintainer, feel free to add me. I have been doing quite some work around the beam set recently |
@yurrriq how about proceeding the other way around. Just adding people who have reacted. |
My intention was for this Draft PR to start these discussions regarding desired team members. Part of the reason it's marked as a draft is to ensure we don't make any changes without consent and buy-in from all involved. I figured it was better to have something tangible to discuss. To be clear for those that have requested to be removed, as this PR exists currently, that would also remove you as maintainers of the specific BEAM packages. Is that the desired effect? |
I've force pushed the following updates:
|
@DianaOlympos, it looks like we'll need to add you to |
I am fine with being added to this list with the caveat that I do not currently have a lot of time, at least until this virus clears up a little more in my area. |
@yurrriq I would say yes to setting the beam team for pgsql, webdriver and hex. |
@yurrriq Thanks for asking, unfortunately I don't have time for this at the moment (and - again unfortunately - I'm not using any BEAM languages for the time being :)) |
Done. As I see it, we're waiting on feedback from Eric Merritt |
@yurrriq @SuperSandro2000 |
Looks like his last contribution was in 2016, so that seems fair to me. |
I do not have much time for BEAM in Nixpkgs lately. I can not promise swift response, so If you need backup people on the list, feel free to include me. |
@SuperSandro2000 when you have a moment, please take a look. No problem if you are busy. |
is the list complete now? |
@Mic92 yes that is my understanding. |
I'd say it's complete for now anyway. |
I could not invite @DianaOlympos to https://github.com/orgs/NixOS/teams/beam, because he is not in the nixos organisation yet. |
@Mic92 i am in now |
fixed. |
Thanks, @Mic92 and @DianaOlympos! |
Motivation for this change
Add a beam team to better coordinate maintenance of BEAM-related packages and modules.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)