The JACK and PulseAudio audio backends are optional. This change allows users to enable or disable support for them.

Is there a compelling reason to disable them? Options which serve no real benefit should be avoided.

The JACK and PulseAudio audio backends are optional. This change allows users to enable or disable support for them.

Is there a compelling reason to disable them? Options which serve no real benefit should be avoided.

Adding such an option might be useful to avoid having to include PulseAudio and JACK on a system where reaper exclusively manages the audio device through ALSA.

Adding such an option might be useful to avoid having to include PulseAudio and JACK on a system where reaper exclusively manages the audio device through ALSA.

This would mean we would only need an option like disablePulseAudio. I want to avoid adding options for things no one uses or tests.

Adding such an option might be useful to avoid having to include PulseAudio and JACK on a system where reaper exclusively manages the audio device through ALSA.

This would mean we would only need an option like disablePulseAudio. I want to avoid adding options for things no one uses or tests.

I don't see why we should add an option for only one of the two backends that are marked as optional in the readme-linux.txt inside the binary tarball.
I think the jackSupport and pulseaudioSupport options make most sense to me instead of inverting the option since it is consistent with many existing packages that use JACK or PulseAudio. Examples include:

• nixpkgs/pkgs/applications/audio/fmit/default.nix

  Line 3 in d8d06d1

  , jackSupport ? false, libjack2 ? null

• nixpkgs/pkgs/applications/audio/cmus/default.nix

  Lines 7 to 10 in e2fcf81

  	, jackSupport ? false, libjack ? null
  	, samplerateSupport ? jackSupport, libsamplerate ? null
  	, ossSupport ? false, alsaOss ? null
  	, pulseaudioSupport ? config.pulseaudio or false, libpulseaudio ? null

• nixpkgs/pkgs/applications/audio/moc/default.nix

  Lines 5 to 6 in e2fcf81

  	, pulseSupport ? true, libpulseaudio, autoreconfHook
  	, jackSupport ? true, libjack2

I don't see why we should add an option for only one of the two backends that are marked as optional in the readme-linux.txt inside the binary tarball.

Because we do not follow those upstream recommendations all the time. Usually nixpkgs packages are build with all available options if they work together and there is no other compelling reason to disable them. Incase of qemu there is a full packages with almost all options and a slim one with only the most necessary options for tests IIRC.

I think the jackSupport and pulseaudioSupport options make most sense to me instead of inverting the option since it is consistent with many existing packages that use JACK or PulseAudio. Examples include:

Okay then we leave them like this.

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110582 run on x86_64-linux 1