Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elmPackages.elm-json: fix darwin build #110598

Merged
merged 1 commit into from Jan 23, 2021

Conversation

turboMaCk
Copy link
Member

@turboMaCk turboMaCk commented Jan 23, 2021

Fix macos build of elm-json

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Can't test this myself. @BrianHicks can you test this on macos?

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Jan 23, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110598 run on x86_64-darwin 1

2 packages built:
  • elmPackages.elm-json
  • elmPackages.elm-review

@turboMaCk
Copy link
Member Author

turboMaCk commented Jan 23, 2021

It gave a me a reason to update and rescue my old macbook pro and to turn it to my personal darwin build server.

✔️ fixes darwin build, binary works

@turboMaCk
Copy link
Member Author

@GrahamcOfBorg build elmPackages.elm-json elmPackages.elm-review

@turboMaCk
Copy link
Member Author

@domenkozar This seems is ready for review/merge

@domenkozar domenkozar merged commit 5562fc6 into NixOS:master Jan 23, 2021
@turboMaCk turboMaCk deleted the elm-json-darwin branch January 23, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants