Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomachine-client: 6.12.3 -> 7.0.211 #110632

Merged
merged 1 commit into from Jan 28, 2021
Merged

nomachine-client: 6.12.3 -> 7.0.211 #110632

merged 1 commit into from Jan 28, 2021

Conversation

austinbutler
Copy link
Member

@austinbutler austinbutler commented Jan 23, 2021 •
edited

Motivation for this change

Upgrade to latest.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@austinbutler
Copy link
Member Author

Result of nixpkgs-review pr 110632 run on x86_64-linux 1

1 package built:
  • nomachine-client

@austinbutler
Copy link
Member Author

Result of nixpkgs-review pr 110632 run on x86_64-linux 1

1 package built:
  • nomachine-client

@talyz
Copy link
Contributor

talyz commented Jan 28, 2021

Result of nixpkgs-review pr 110632 run on x86_64-linux 1

1 package built:
  • nomachine-client

@talyz talyz added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 28, 2021
@talyz
Copy link
Contributor

talyz commented Jan 28, 2021

Tried connecting to a remote machine and everything seems to work well. Thanks!

@talyz talyz merged commit ed8d40c into NixOS:master Jan 28, 2021
@talyz talyz mentioned this pull request Jan 30, 2021
Merged
10 tasks
@talyz talyz added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 30, 2021
@austinbutler austinbutler deleted the nomachine-client-7 branch May 24, 2021 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyz talyz Awaiting requested review from talyz

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@austinbutler @talyz @SuperSandro2000