Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgs/development/interpreters: stdenv.lib -> lib #110591

Merged
merged 1 commit into from Jan 23, 2021
Merged

pkgs/development/interpreters: stdenv.lib -> lib #110591

merged 1 commit into from Jan 23, 2021

Conversation

siraben
Copy link
Member

@siraben siraben commented Jan 23, 2021

Motivation for this change

Part of #108938

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Can you check lumo and maybe move it to a different PR?

@siraben
Copy link
Member Author

siraben commented Jan 23, 2021 

diff --git a/pkgs/development/interpreters/clojurescript/lumo/default.nix b/pkgs/development/interpreters/clojurescript/lumo/default.nix
index 61fd94c09bf..a269d0b158e 100644
--- a/pkgs/development/interpreters/clojurescript/lumo/default.nix
+++ b/pkgs/development/interpreters/clojurescript/lumo/default.nix
@@ -280,8 +280,8 @@ stdenv.mkDerivation {
       making it the fastest Clojure REPL in existence.
     '';
     homepage = "https://github.com/anmonteiro/lumo";
-    license = stdenv.lib.licenses.epl10;
-    maintainers = [ stdenv.lib.maintainers.hlolli ];
-    platforms = stdenv.lib.platforms.linux ++ stdenv.lib.platforms.darwin;
+    license = lib.licenses.epl10;
+    maintainers = [ lib.maintainers.hlolli ];
+    platforms = lib.platforms.linux ++ lib.platforms.darwin;
   };
 }

@SuperSandro2000 SuperSandro2000 merged commit 79c6102 into NixOS:master Jan 23, 2021
@siraben siraben deleted the interpreters-stdenv-lib branch January 23, 2021 15:15
@andersk andersk mentioned this pull request Feb 14, 2021
Merged
10 tasks
FRidh pushed a commit that referenced this pull request Feb 20, 2021
@andersk @FRidh
pythonInterpreters.pypy36_prebuilt: Add missing lib argument
1c5c184 
This was broken by commit 001c0cb
(#110591).

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais Awaiting requested review from alyssais

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@stigtsp stigtsp Awaiting requested review from stigtsp stigtsp is a code owner

Assignees
No one assigned
Labels
6.topic: erlang 6.topic: lua 6.topic: python 6.topic: ruby 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@siraben @SuperSandro2000