Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxqt: fix oxygen-icons5 attribute path #110594

Merged
merged 1 commit into from Jan 24, 2021
Merged

lxqt: fix oxygen-icons5 attribute path #110594

merged 1 commit into from Jan 24, 2021

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jan 23, 2021

Motivation for this change

kdeFrameworks.oxygen-icons5 does not exist anymore. Use libsForQt5.oxygen-icons5 instead.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo
lxqt: fix oxygen-icons5 attribute path
7c5dc02 
kdeFrameworks.oxygen-icons5 does not exist anymore
@bjornfor bjornfor merged commit fd3d62b into NixOS:master Jan 24, 2021
@romildo romildo deleted the fix.lxqt branch January 24, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romildo @bjornfor