[OSX] Cleanup video driver. #8652
Conversation
michicc
force-pushed
the
pr/osx_cleanup_2
branch
3 times, most recently
from
9e51895 to
80d4759
Compare
michicc
force-pushed
the
pr/osx_cleanup_2
branch
3 times, most recently
from
52da7c7 to
2516f27
Compare
| */ | ||
| bool VideoDriver_Cocoa::IsFullscreen() | ||
| { | ||
| return this->window != nil && ([ this->window styleMask ] & NSWindowStyleMaskFullScreen) != 0; |
There was a problem hiding this comment.
I suppose nil is some objective C thing? Should be consistent on nullptr/nil/NULL I suppose
There was a problem hiding this comment.
Yes, nil is Objective-C. It is supposed to be consistent in the sense that Obj-C types are compared with nil and C/C++ pointers with nullptr.
| { | ||
| driver = drv; | ||
| if (self = [ super init ]) { |
There was a problem hiding this comment.
I suppose the = is intentional? Could use (()) to make it more obviously intentional?
There was a problem hiding this comment.
Common Objective-C ideom and usually written like this. I can add ()s if necessary.
|
@LordAro General note: many things are just literal copy/paste from before, but I can certainly fix some of the most egregious things. |
|
Testing on my 2019 MacBook Pro, graphics performance does seem better with this patch. |
…zes. We never change the real screen resolution on OSX. As such, offering a list of resolutions is pointless. Instead of that, offer the user a list of commonly used window sizes up to the current screen size.
This allows the drawing backend code to be independent of any event or command handling.
It wasn't displayed anyway as it was never copied to the bundle.
michicc
force-pushed
the
pr/osx_cleanup_2
branch
from
9a070aa to
4b9007b
Compare
Motivation / Problem / D
The OSX video driver is quite messy and littered with remnants of the old subdriver architecture. As only one subdriver is left, most of it can be cleaned up.
There are also a lot of cargo-culted things that make it quite different from the other drivers and/or are simply useless for us.
Description
This PR tries to clean up the most egregious things and switches to using newer APIs where useful.
Mouse tracking changed to newer APIs. Also, using a layer-backed view improves draw performance.
Limitations
Cocoa OSX design is very different from e.g. Win32 or SDL, so the video driver is still quite different from the other drivers.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.