-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace outdated Mercurial stuff, update README #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable
Please test if it still builds for you without error! That's really important. :D |
I haven't tested this, but given there were issues with the equivalent changeset on OpenSFX, I suspect we'll basically need to copy those same changes over. Also the appropriate GitHub Actions infrastructure. |
I've looked at the script again, and and OpenSFX, and made the following changes:
As for GitHub Actions, I suggest to do this stuff separately (different PR). |
I just pulled the branch and tried to build it, yet it failed. The problem here is case: you should use consequently SHELL |
No? Well, kinda, but not quite. $(shell ...) is the function, SHELL is the variable that sets the shell to use. Is https://www.gnu.org/software/make/manual/html_node/Shell-Function.html |
Well, it works for me. *shrug* |
If in doubt, just copy what already works (OpenSFX). :) The whole lot should be squashed into a single commit, but that can be done at merge time. I'll have a look at the rest of the changes. |
I agree all the commits should be squashed at the end, but not now, before the review/approval is done. |
Fixes #5. Fixes #6.
This PR updates the README and fixes many outdated instructions, links and references to Mercurial-related stuff to replace it with Git-related stuff.
This PR also updates the Makefiles and
.hgignore
.