Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set resource requests' parameters for module service workers scripts. #27559

Merged
merged 1 commit into from Feb 23, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 10, 2021

This CL sets parameters of resource requests for module service workers
scripts as follows:

  • Main module:
    • mode: cors
    • credentials mode: omit
    • Service-Worker header: script
    • SSL-info: set
  • Static-imported module:
    • mode: cors
    • credentials mode: omit
    • Service-Worker header: script
    • SSL-info: not set

Bug: 1168834
Change-Id: Ib6181710aa96391fd526ba14f6409d4c9c75a2a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2670289
Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#856532}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2670289 branch 5 times, most recently from 5c79aa4 to ff019c9 Compare February 19, 2021 20:16
@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Set mode and credentials mode for a service worker served as a module Set resource requests' parameters for module service workers scripts. Feb 22, 2021
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2670289 branch 4 times, most recently from 131bb94 to de4ad62 Compare February 22, 2021 23:10
This CL sets parameters of resource requests for module service workers
scripts as follows:
  - Main module:
    - mode: cors
    - credentials mode: omit
    - Service-Worker header: script
    - SSL-info: set
  - Static-imported module:
    - mode: cors
    - credentials mode: omit
    - Service-Worker header: script
    - SSL-info: not set

Bug: 1168834
Change-Id: Ib6181710aa96391fd526ba14f6409d4c9c75a2a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2670289
Commit-Queue: Ghazale Hosseinabadi <ghazale@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#856532}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants