Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode: fix update script #110096

Merged
merged 3 commits into from Feb 1, 2021

Conversation

samuela
Copy link
Member

@samuela samuela commented Jan 20, 2021

Motivation for this change

Microsoft changed its website format, and the latest version info is no longer displayed. I updated the script to pull the latest VSCode version from their GitHub releases instead. This is a lot more straightforward and should be more robust going forward.

I've tested both:

  • no relevant update available, script doesn't change anything
  • there's an update available and the script goes through the update process
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after): no impact
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/337

@SuperSandro2000 SuperSandro2000 merged commit bbc0f1c into NixOS:master Feb 1, 2021
@samuela samuela deleted the samuela/fix-vscode-update branch February 1, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants