Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convos: 5.00 -> 5.11 #110054

Merged
merged 5 commits into from Jan 23, 2021
Merged

convos: 5.00 -> 5.11 #110054

merged 5 commits into from Jan 23, 2021

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Jan 20, 2021 •
edited

Motivation for this change

https://github.com/Nordaaker/convos/blob/5.11/Changes

dependencies:
perlPackages.HTTPAcceptLanguage: init at 0.02
perlPackages.LinkEmbedder: 1.15 -> 1.16
perlPackages.Mojolicious: 8.67 -> 8.71
perlPackages.MojoliciousPluginWebpack: 0.13 -> 0.14

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

50 packages built:
  • abcde
  • convos
  • perl530Packages.HTTPAcceptLanguage
  • perl530Packages.JSONValidator
  • perl530Packages.LinkEmbedder
  • perl530Packages.Minion
  • perl530Packages.MinionBackendSQLite
  • perl530Packages.MinionBackendmysql
  • perl530Packages.MojoIOLoopForkCall
  • perl530Packages.MojoJWT
  • perl530Packages.MojoPg
  • perl530Packages.MojoRedis
  • perl530Packages.MojoSAML
  • perl530Packages.MojoSQLite
  • perl530Packages.MojoUserAgentCached
  • perl530Packages.Mojolicious
  • perl530Packages.MojoliciousPluginAssetPack
  • perl530Packages.MojoliciousPluginGravatar
  • perl530Packages.MojoliciousPluginMail
  • perl530Packages.MojoliciousPluginOpenAPI
  • perl530Packages.MojoliciousPluginStatus
  • perl530Packages.MojoliciousPluginTextExceptions
  • perl530Packages.MojoliciousPluginWebpack
  • perl530Packages.Mojomysql
  • perl530Packages.MusicBrainz
  • perl530Packages.OpenAPIClient
  • perl532Packages.HTTPAcceptLanguage
  • perl532Packages.JSONValidator
  • perl532Packages.LinkEmbedder
  • perl532Packages.Minion
  • perl532Packages.MinionBackendSQLite
  • perl532Packages.MinionBackendmysql
  • perl532Packages.MojoIOLoopForkCall
  • perl532Packages.MojoJWT
  • perl532Packages.MojoPg
  • perl532Packages.MojoRedis
  • perl532Packages.MojoSAML
  • perl532Packages.MojoSQLite
  • perl532Packages.MojoUserAgentCached
  • perl532Packages.Mojolicious
  • perl532Packages.MojoliciousPluginAssetPack
  • perl532Packages.MojoliciousPluginGravatar
  • perl532Packages.MojoliciousPluginMail
  • perl532Packages.MojoliciousPluginOpenAPI
  • perl532Packages.MojoliciousPluginStatus
  • perl532Packages.MojoliciousPluginTextExceptions
  • perl532Packages.MojoliciousPluginWebpack
  • perl532Packages.Mojomysql
  • perl532Packages.MusicBrainz
  • perl532Packages.OpenAPIClient

Tested OK on linux x64 and darwin x64.

@stigtsp stigtsp marked this pull request as draft January 20, 2021 01:47
@stigtsp stigtsp marked this pull request as ready for review January 20, 2021 01:57
@zakame
Copy link
Member

zakame commented Jan 20, 2021

Result of nixpkgs-review pr 110054 run on Other x86_64-linux 1

50 packages built:
  • abcde
  • convos
  • perl530Packages.HTTPAcceptLanguage
  • perl530Packages.JSONValidator
  • perl530Packages.LinkEmbedder
  • perl530Packages.Minion
  • perl530Packages.MinionBackendSQLite
  • perl530Packages.MinionBackendmysql
  • perl530Packages.MojoIOLoopForkCall
  • perl530Packages.MojoJWT
  • perl530Packages.MojoPg
  • perl530Packages.MojoRedis
  • perl530Packages.MojoSAML
  • perl530Packages.MojoSQLite
  • perl530Packages.MojoUserAgentCached
  • perl530Packages.Mojolicious
  • perl530Packages.MojoliciousPluginAssetPack
  • perl530Packages.MojoliciousPluginGravatar
  • perl530Packages.MojoliciousPluginMail
  • perl530Packages.MojoliciousPluginOpenAPI
  • perl530Packages.MojoliciousPluginStatus
  • perl530Packages.MojoliciousPluginTextExceptions
  • perl530Packages.MojoliciousPluginWebpack
  • perl530Packages.Mojomysql
  • perl530Packages.MusicBrainz
  • perl530Packages.OpenAPIClient
  • perl532Packages.HTTPAcceptLanguage
  • perl532Packages.JSONValidator
  • perl532Packages.LinkEmbedder
  • perl532Packages.Minion
  • perl532Packages.MinionBackendSQLite
  • perl532Packages.MinionBackendmysql
  • perl532Packages.MojoIOLoopForkCall
  • perl532Packages.MojoJWT
  • perl532Packages.MojoPg
  • perl532Packages.MojoRedis
  • perl532Packages.MojoSAML
  • perl532Packages.MojoSQLite
  • perl532Packages.MojoUserAgentCached
  • perl532Packages.Mojolicious
  • perl532Packages.MojoliciousPluginAssetPack
  • perl532Packages.MojoliciousPluginGravatar
  • perl532Packages.MojoliciousPluginMail
  • perl532Packages.MojoliciousPluginOpenAPI
  • perl532Packages.MojoliciousPluginStatus
  • perl532Packages.MojoliciousPluginTextExceptions
  • perl532Packages.MojoliciousPluginWebpack
  • perl532Packages.Mojomysql
  • perl532Packages.MusicBrainz
  • perl532Packages.OpenAPIClient

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 110054 run on x86_64-darwin 1

47 packages failed to build and are new build failures:
  • convos: log was empty
  • perl530Packages.JSONValidator: log was empty
  • perl530Packages.LinkEmbedder: log was empty
  • perl530Packages.Minion: log was empty
  • perl530Packages.MinionBackendSQLite: log was empty
  • perl530Packages.MinionBackendmysql: log was empty
  • perl530Packages.MojoIOLoopForkCall: log was empty
  • perl530Packages.MojoJWT: log was empty
  • perl530Packages.MojoPg: log was empty
  • perl530Packages.MojoRedis: log was empty
  • perl530Packages.MojoSAML: log was empty
  • perl530Packages.MojoSQLite: log was empty
  • perl530Packages.MojoUserAgentCached: log was empty
  • perl530Packages.Mojolicious: log https://termbin.com/trov
  • perl530Packages.MojoliciousPluginAssetPack: log was empty
  • perl530Packages.MojoliciousPluginGravatar: log was empty
  • perl530Packages.MojoliciousPluginMail: log was empty
  • perl530Packages.MojoliciousPluginOpenAPI: log was empty
  • perl530Packages.MojoliciousPluginStatus: log was empty
  • perl530Packages.MojoliciousPluginTextExceptions: log was empty
  • perl530Packages.MojoliciousPluginWebpack: log was empty
  • perl530Packages.Mojomysql: log was empty
  • perl530Packages.MusicBrainz: log was empty
  • perl530Packages.OpenAPIClient: log was empty
  • perl532Packages.JSONValidator: log was empty
  • perl532Packages.LinkEmbedder: log was empty
  • perl532Packages.Minion: log was empty
  • perl532Packages.MinionBackendSQLite: log was empty
  • perl532Packages.MinionBackendmysql: log was empty
  • perl532Packages.MojoIOLoopForkCall: log was empty
  • perl532Packages.MojoJWT: log was empty
  • perl532Packages.MojoPg: log was empty
  • perl532Packages.MojoRedis: log was empty
  • perl532Packages.MojoSAML: log was empty
  • perl532Packages.MojoSQLite: log was empty
  • perl532Packages.MojoUserAgentCached: log was empty
  • perl532Packages.Mojolicious: log https://termbin.com/mf6s
  • perl532Packages.MojoliciousPluginAssetPack: log was empty
  • perl532Packages.MojoliciousPluginGravatar: log was empty
  • perl532Packages.MojoliciousPluginMail: log was empty
  • perl532Packages.MojoliciousPluginOpenAPI: log was empty
  • perl532Packages.MojoliciousPluginStatus: log was empty
  • perl532Packages.MojoliciousPluginTextExceptions: log was empty
  • perl532Packages.MojoliciousPluginWebpack: log was empty
  • perl532Packages.Mojomysql: log was empty
  • perl532Packages.MusicBrainz: log was empty
  • perl532Packages.OpenAPIClient: log was empty
2 packages built:
  • perl530Packages.HTTPAcceptLanguage
  • perl532Packages.HTTPAcceptLanguage

@stigtsp
Copy link
Member Author

stigtsp commented Jan 20, 2021

Result of nixpkgs-review pr 110054 run on x86_64-darwin 1
47 packages failed to build and are new build failures:

The checkPhase for Mojolicious seems to cause the problem - from https://termbin.com/mf6s:

t/mojo/daemon.t ............................ 1/? 
#   Failed test 'No tests run for subtest "Minimal application"'
#   at t/mojo/daemon.t line 35.
Can't create listen socket: Operation not permitted at /private/tmp/nix-build-perl5.30.3-Mojolicious-8.71.drv-0/Mojolicious-8.71/blib/lib/Mojo/IOLoop.pm line 130.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 255 just after 1.

I'm able to reproduce this problem on my darwin x64 running macOS 10.15.7 under nixpkgs-review, however nix-build -A convos and nix-build -A perlPackages.Mojolicious works fine. Some sandboxing on darwin seems to cause problems binding to localhost I think.

@SuperSandro2000
Copy link
Member

I'm able to reproduce this problem on my darwin x64 running macOS 10.15.7 under nixpkgs-review, however nix-build -A convos and nix-build -A perlPackages.Mojolicious works fine. Some sandboxing on darwin seems to cause problems binding to localhost I think.

I think this, too.

@stigtsp stigtsp requested a review from zakame January 22, 2021 01:11
@stigtsp
Copy link
Member Author

stigtsp commented Jan 23, 2021

Tested OK on linux x64 and darwin x64:

  • Basic functionality works, connected to freenode
  • New SASL EXTERNAL feature works

Ticks all the boxes, will merge.

@stigtsp stigtsp merged commit 2176c7e into NixOS:master Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zakame zakame zakame approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stigtsp @zakame @SuperSandro2000