Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoom-us: Make update script get exact version #110133

Merged
merged 1 commit into from Jan 31, 2021
Merged

zoom-us: Make update script get exact version #110133

merged 1 commit into from Jan 31, 2021

Conversation

doronbehar
Copy link
Contributor

Their website has changed the format in which they display the version,
into something a bit more sophisticated.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar
zoom-us: Make update script get exact version
6d9570e 
Their website has changed the format in which they display the version,
into something a bit more sophisticated.
@doronbehar doronbehar mentioned this pull request Jan 20, 2021
Open
9 tasks
@doronbehar doronbehar requested a review from Mic92 January 20, 2021 10:56
@SuperSandro2000
Copy link
Member

Don't they have some API for updates we could use?

@doronbehar
Copy link
Contributor Author

Don't they have some API for updates we could use?

Not that I know of / could find. Even the download link we use is not documented for as far as I can see.

@SuperSandro2000 SuperSandro2000 merged commit 074a0e0 into NixOS:master Jan 31, 2021
@doronbehar doronbehar deleted the pkg/zoom-us.2 branch March 2, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doronbehar @SuperSandro2000 @bjornfor